linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] btusb: fix zero BD address problem during stress test
@ 2016-10-18 12:57 Amitkumar Karwar
  2016-11-16  6:10 ` Amitkumar Karwar
  0 siblings, 1 reply; 9+ messages in thread
From: Amitkumar Karwar @ 2016-10-18 12:57 UTC (permalink / raw)
  To: linux-bluetooth
  Cc: marcel, linux-kernel, Cathy Luo, Nishant Sarmukadam,
	Ganapathi Bhat, Amitkumar Karwar

From: Ganapathi Bhat <gbhat@marvell.com>

We came across a corner case issue during reboot stress test
in which hciconfig shows BD address is all zero. Reason is we
don't get response for HCI RESET command during initialization

The issue is tracked to a race where USB subsystem calls
btusb_intr_complete() to deliver a data(NOOP frame) received
on interrupt endpoint. HCI_RUNNING flag is not yet set by
bluetooth subsystem. So we ignore that frame and return.

As we missed to resubmit the buffer to interrupt endpoint in
this case, we don't get response for BT reset command downloaded
after this.

This patch handles the corner case to resolve zero BD address
problem.

Signed-off-by: Ganapathi Bhat <gbhat@marvell.com>
Signed-off-by: Amitkumar Karwar <akarwar@marvell.com>
---
 drivers/bluetooth/btusb.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index 811f9b9..b5596ac 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -607,10 +607,7 @@ static void btusb_intr_complete(struct urb *urb)
 	BT_DBG("%s urb %p status %d count %d", hdev->name, urb, urb->status,
 	       urb->actual_length);
 
-	if (!test_bit(HCI_RUNNING, &hdev->flags))
-		return;
-
-	if (urb->status == 0) {
+	if (urb->status == 0 && test_bit(HCI_RUNNING, &hdev->flags)) {
 		hdev->stat.byte_rx += urb->actual_length;
 
 		if (btusb_recv_intr(data, urb->transfer_buffer,
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 9+ messages in thread
end of thread, other threads:[~2016-12-07  9:07 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-18 12:57 [PATCH] btusb: fix zero BD address problem during stress test Amitkumar Karwar
2016-11-16  6:10 ` Amitkumar Karwar
2016-11-22 21:55   ` Marcel Holtmann
2016-11-23  7:50     ` Amitkumar Karwar
2016-11-23  8:16       ` Marcel Holtmann
2016-11-23  9:44         ` Amitkumar Karwar
2016-11-25 11:21         ` Amitkumar Karwar
2016-12-07  7:44         ` Amitkumar Karwar
2016-12-07  9:07           ` Marcel Holtmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).