linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Don Zickus <dzickus@redhat.com>
To: linux-bluetooth@vger.kernel.org
Cc: luiz.dentz@gmail.com, brn@deako.com, Don Zickus <dzickus@redhat.com>
Subject: [RFC 0/3] core/adapter: Add disabling duplicate device filtering from d-bus
Date: Tue,  6 Dec 2016 16:39:57 -0500	[thread overview]
Message-ID: <1481060400-7088-1-git-send-email-dzickus@redhat.com> (raw)

Recent discussions on the bluez mailing list revealed it was not easy
to disable duplicate device filtering from the d-bus interface.

As a result, if I wanted to monitor LE devices entering and leaving the
adapters range (using RSSI data), it was difficult.

This patchset is a dirty hack to make this work. The first patch enables
it on the kernel side, while the other two patches enable it from the bluez
side.

I understand there are concerns about flooding the d-bus interface when
enabling this.  I tried to write a throttling mechanism using the mainloop
as my timer, but soon realized you can only have 1 device RSSI event
per loop, so that wasn't going to work.  Open to suggestions if still a
concern.

Posted as an RFC just to generate discussion.  I expect I missed a lot of
little details here, but wanted to post my proof of concept to see if this
is something to work with.

This patchset includes both the kernel and bluez patches.  I understand this is
not recommended for normal practice.  But I thought for an RFC, it is nice to
keep things together for now.



kernel:

Don Zickus (1):
  bluetooth: Add managment ability to disable duplicate device fitlering

 include/net/bluetooth/hci_core.h | 1 +
 include/net/bluetooth/mgmt.h     | 1 +
 net/bluetooth/hci_request.c      | 2 +-
 net/bluetooth/mgmt.c             | 5 +++++
 4 files changed, 8 insertions(+), 1 deletion(-)


bluez:

Don Zickus (2):
  core/adapter: Add le_duplicates flag to management interface
  core/adapter: Hook le_duplicates into d-bus interface

 client/main.c       |  5 +++++
 doc/adapter-api.txt |  1 +
 lib/mgmt.h          |  1 +
 src/adapter.c       | 37 +++++++++++++++++++++++++++++++------
 4 files changed, 38 insertions(+), 6 deletions(-)

-- 
1.8.3.1


             reply	other threads:[~2016-12-06 21:39 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-06 21:39 Don Zickus [this message]
2016-12-06 21:39 ` [RFC 1/3] bluetooth: Add managment ability to disable duplicate device fitlering Don Zickus
2016-12-06 21:39 ` [RFC 2/3] core/adapter: Add le_duplicates flag to management interface Don Zickus
2016-12-06 21:40 ` [RFC 3/3] core/adapter: Hook le_duplicates into d-bus interface Don Zickus
2016-12-07 10:21 ` [RFC 0/3] core/adapter: Add disabling duplicate device filtering from d-bus Luiz Augusto von Dentz
2016-12-07 20:16   ` Don Zickus
2016-12-08  6:18     ` Marcel Holtmann
2016-12-08 12:29       ` Northfield Stuart
2016-12-08 16:04         ` Don Zickus
2016-12-08 21:07           ` Marcel Holtmann
2016-12-12 19:12             ` Don Zickus
2016-12-08 20:13         ` Brennan Ashton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1481060400-7088-1-git-send-email-dzickus@redhat.com \
    --to=dzickus@redhat.com \
    --cc=brn@deako.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).