linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] android: Fix bluetoothd installation path
@ 2014-01-08 16:42 Andrzej Kaczmarek
  2014-01-08 16:57 ` Szymon Janc
  0 siblings, 1 reply; 3+ messages in thread
From: Andrzej Kaczmarek @ 2014-01-08 16:42 UTC (permalink / raw)
  To: linux-bluetooth; +Cc: Andrzej Kaczmarek

This patch removes explicit LOCAL_MODULE_PATH definition for bluetoothd
and bluetoothd-snoop modules which caused both binaries to be installed
in /system/xbin instead of /system/bin folder.
---
 android/Android.mk | 2 --
 1 file changed, 2 deletions(-)

diff --git a/android/Android.mk b/android/Android.mk
index 16339b1..8eb918e 100644
--- a/android/Android.mk
+++ b/android/Android.mk
@@ -75,7 +75,6 @@ $(shell mkdir -p $(LOCAL_PATH)/../lib/bluetooth)
 
 $(foreach file,$(lib_headers), $(shell ln -sf ../$(file) $(LOCAL_PATH)/../lib/bluetooth/$(file)))
 
-LOCAL_MODULE_PATH := $(TARGET_OUT_OPTIONAL_EXECUTABLES)
 LOCAL_MODULE_TAGS := optional
 LOCAL_MODULE := bluetoothd
 
@@ -264,7 +263,6 @@ LOCAL_C_INCLUDES := \
 
 LOCAL_CFLAGS := $(BLUEZ_COMMON_CFLAGS)
 
-LOCAL_MODULE_PATH := $(TARGET_OUT_OPTIONAL_EXECUTABLES)
 LOCAL_MODULE_TAGS := optional
 LOCAL_MODULE := bluetoothd-snoop
 
-- 
1.8.5.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] android: Fix bluetoothd installation path
  2014-01-08 16:42 [PATCH] android: Fix bluetoothd installation path Andrzej Kaczmarek
@ 2014-01-08 16:57 ` Szymon Janc
  2014-01-09  8:36   ` Andrei Emeltchenko
  0 siblings, 1 reply; 3+ messages in thread
From: Szymon Janc @ 2014-01-08 16:57 UTC (permalink / raw)
  To: Andrzej Kaczmarek; +Cc: linux-bluetooth

Hi Andrzej,

On Wednesday 08 January 2014 17:42:01 Andrzej Kaczmarek wrote:
> This patch removes explicit LOCAL_MODULE_PATH definition for bluetoothd
> and bluetoothd-snoop modules which caused both binaries to be installed
> in /system/xbin instead of /system/bin folder.
> ---
>  android/Android.mk | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/android/Android.mk b/android/Android.mk
> index 16339b1..8eb918e 100644
> --- a/android/Android.mk
> +++ b/android/Android.mk
> @@ -75,7 +75,6 @@ $(shell mkdir -p $(LOCAL_PATH)/../lib/bluetooth)
> 
>  $(foreach file,$(lib_headers), $(shell ln -sf ../$(file)
> $(LOCAL_PATH)/../lib/bluetooth/$(file)))
> 
> -LOCAL_MODULE_PATH := $(TARGET_OUT_OPTIONAL_EXECUTABLES)
>  LOCAL_MODULE_TAGS := optional
>  LOCAL_MODULE := bluetoothd
> 
> @@ -264,7 +263,6 @@ LOCAL_C_INCLUDES := \
> 
>  LOCAL_CFLAGS := $(BLUEZ_COMMON_CFLAGS)
> 
> -LOCAL_MODULE_PATH := $(TARGET_OUT_OPTIONAL_EXECUTABLES)
>  LOCAL_MODULE_TAGS := optional
>  LOCAL_MODULE := bluetoothd-snoop

Applied, thanks.

-- 
Szymon K. Janc
szymon.janc@gmail.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] android: Fix bluetoothd installation path
  2014-01-08 16:57 ` Szymon Janc
@ 2014-01-09  8:36   ` Andrei Emeltchenko
  0 siblings, 0 replies; 3+ messages in thread
From: Andrei Emeltchenko @ 2014-01-09  8:36 UTC (permalink / raw)
  To: Szymon Janc; +Cc: Andrzej Kaczmarek, linux-bluetooth

Hi All,

On Wed, Jan 08, 2014 at 05:57:22PM +0100, Szymon Janc wrote:
> Hi Andrzej,
> 
> On Wednesday 08 January 2014 17:42:01 Andrzej Kaczmarek wrote:
> > This patch removes explicit LOCAL_MODULE_PATH definition for bluetoothd
> > and bluetoothd-snoop modules which caused both binaries to be installed
> > in /system/xbin instead of /system/bin folder.
> > ---
> >  android/Android.mk | 2 --
> >  1 file changed, 2 deletions(-)
> > 
> > diff --git a/android/Android.mk b/android/Android.mk
> > index 16339b1..8eb918e 100644
> > --- a/android/Android.mk
> > +++ b/android/Android.mk
> > @@ -75,7 +75,6 @@ $(shell mkdir -p $(LOCAL_PATH)/../lib/bluetooth)
> > 
> >  $(foreach file,$(lib_headers), $(shell ln -sf ../$(file)
> > $(LOCAL_PATH)/../lib/bluetooth/$(file)))
> > 
> > -LOCAL_MODULE_PATH := $(TARGET_OUT_OPTIONAL_EXECUTABLES)

I would better change this to:

LOCAL_MODULE_PATH := $(TARGET_OUT_EXECUTABLES)

Best regards 
Andrei Emeltchenko 

> >  LOCAL_MODULE_TAGS := optional
> >  LOCAL_MODULE := bluetoothd
> > 
> > @@ -264,7 +263,6 @@ LOCAL_C_INCLUDES := \
> > 
> >  LOCAL_CFLAGS := $(BLUEZ_COMMON_CFLAGS)
> > 
> > -LOCAL_MODULE_PATH := $(TARGET_OUT_OPTIONAL_EXECUTABLES)
> >  LOCAL_MODULE_TAGS := optional
> >  LOCAL_MODULE := bluetoothd-snoop
> 
> Applied, thanks.
> 
> -- 
> Szymon K. Janc
> szymon.janc@gmail.com
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-01-09  8:36 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-08 16:42 [PATCH] android: Fix bluetoothd installation path Andrzej Kaczmarek
2014-01-08 16:57 ` Szymon Janc
2014-01-09  8:36   ` Andrei Emeltchenko

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).