Linux bluetooth development
 help / color / mirror / Atom feed
From: Xinming Hu <huxm@marvell.com>
To: Linux Bluetooth <linux-bluetooth@vger.kernel.org>
Cc: Marcel Holtmann <marcel@holtmann.org>,
	Amitkumar Karwar <akarwar@marvell.com>,
	Cathy Luo <cluo@marvell.com>, Xinming Hu <huxm@marvell.com>,
	Guenter Roeck <groeck@chromium.org>
Subject: [PATCH 2/2] Bluetooth: btmrvl: remove unnecessary wakeup interrupt number sanity check
Date: Thu, 30 Mar 2017 20:52:44 +0800	[thread overview]
Message-ID: <1490878364-2735-2-git-send-email-huxm@marvell.com> (raw)
In-Reply-To: <1490878364-2735-1-git-send-email-huxm@marvell.com>

Sanity check of interrupt number in interrupt handler is unnecessary and
confusion, remove it.

Signed-off-by: Xinming Hu <huxm@marvell.com>
Signed-off-by: Guenter Roeck <groeck@chromium.org>
Signed-off-by: Amitkumar Karwar <akarwar@marvell.com>
---
 drivers/bluetooth/btmrvl_sdio.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/bluetooth/btmrvl_sdio.c b/drivers/bluetooth/btmrvl_sdio.c
index 6166888..7a26961 100644
--- a/drivers/bluetooth/btmrvl_sdio.c
+++ b/drivers/bluetooth/btmrvl_sdio.c
@@ -62,12 +62,9 @@ static irqreturn_t btmrvl_wake_irq_bt(int irq, void *priv)
 {
 	struct btmrvl_plt_wake_cfg *cfg = priv;
 
-	if (cfg->irq_bt >= 0) {
-		pr_info("%s: wake by bt", __func__);
-		cfg->wake_by_bt = true;
-		disable_irq_nosync(irq);
-	}
-
+	pr_info("%s: wake by bt", __func__);
+	cfg->wake_by_bt = true;
+	disable_irq_nosync(irq);
 	return IRQ_HANDLED;
 }
 
-- 
1.8.1.4

  reply	other threads:[~2017-03-30 12:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-30 12:52 [PATCH 1/2] Bluetooth: btmrvl: disable platform wakeup interrupt in suspend failure path Xinming Hu
2017-03-30 12:52 ` Xinming Hu [this message]
2017-03-30 12:57   ` [PATCH 2/2] Bluetooth: btmrvl: remove unnecessary wakeup interrupt number sanity check Guenter Roeck
2017-03-30 13:17     ` [EXT] " Xinming Hu
2017-03-30 15:00       ` Guenter Roeck
2017-03-30 14:20   ` Marcel Holtmann
2017-03-30 14:38     ` Xinming Hu
2017-03-30 14:21 ` [PATCH 1/2] Bluetooth: btmrvl: disable platform wakeup interrupt in suspend failure path Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1490878364-2735-2-git-send-email-huxm@marvell.com \
    --to=huxm@marvell.com \
    --cc=akarwar@marvell.com \
    --cc=cluo@marvell.com \
    --cc=groeck@chromium.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=marcel@holtmann.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox