From: nsathish41@gmail.com
To: linux-bluetooth@vger.kernel.org
Cc: Sathish Narasimman <sathish.narasimman@intel.com>
Subject: [PATCH BlueZ 1/2] obexd/map: Do not send parent folder in dummy
Date: Fri, 9 Jun 2017 10:53:27 +0530 [thread overview]
Message-ID: <1496985808-17492-1-git-send-email-nsathish41@gmail.com> (raw)
From: Sathish Narasimman <sathish.narasimman@intel.com>
In messages-dummy it is not necessary to add parent folder in the
response to folder-lisintg. when tested with some carkit the present
method is not working when navigating to different folders. so removing
it.
---
obexd/plugins/messages-dummy.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/obexd/plugins/messages-dummy.c b/obexd/plugins/messages-dummy.c
index 765f08d..33056e2 100644
--- a/obexd/plugins/messages-dummy.c
+++ b/obexd/plugins/messages-dummy.c
@@ -155,16 +155,6 @@ static void return_folder_listing(struct folder_listing_data *fld, GSList *list)
uint16_t num = 0;
uint16_t offs = 0;
- /* XXX: This isn't really documented for MAP. I need to take a look how
- * other implementations choose to deal with parent folder.
- */
- if (session->cwd[0] != 0 && fld->offset == 0) {
- num++;
- fld->callback(session, -EAGAIN, 0, "..", fld->user_data);
- } else {
- offs++;
- }
-
for (cur = list; offs < fld->offset; offs++) {
cur = cur->next;
if (cur == NULL)
--
2.7.4
next reply other threads:[~2017-06-09 5:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-09 5:23 nsathish41 [this message]
2017-06-09 5:23 ` [PATCH BlueZ 2/2] obexd/map: msg dummy implement message listing nsathish41
2017-06-09 12:55 ` Luiz Augusto von Dentz
2017-06-12 7:20 ` Sathish Narasimman
-- strict thread matches above, loose matches on Subject: below --
2017-06-08 15:14 [PATCH BlueZ 0/2] *** SUBJECT HERE *** nsathish41
2017-06-08 15:14 ` [PATCH BlueZ 1/2] obexd/map: Do not send parent folder in dummy nsathish41
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1496985808-17492-1-git-send-email-nsathish41@gmail.com \
--to=nsathish41@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=sathish.narasimman@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox