From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <1500367310.502.0.camel@suse.com> Subject: Re: [RFC PATCH v2] Bluetooth: btusb: Fix memory leak in play_deferred From: Oliver Neukum To: jeffy , Marcel Holtmann Cc: briannorris@chromium.org, dianders@chromium.org, Johan Hedberg , xiyou.wangcong@gmail.com, "Gustavo F. Padovan" , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 18 Jul 2017 10:41:50 +0200 In-Reply-To: <596DC200.1080006@rock-chips.com> References: <1500343579-9831-1-git-send-email-jeffy.chen@rock-chips.com> <6E21F79E-93AA-4461-BA6B-67715501714F@holtmann.org> <1500363015.16072.5.camel@suse.com> <596DC200.1080006@rock-chips.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 List-ID: Am Dienstag, den 18.07.2017, 16:08 +0800 schrieb jeffy: > > I am afraid not. We cannot silently drop one part of a transmission. > > I am afraid that the correct algorithm, if we encounter an error at > > that stage, is to abort the operation and report an error. > > > so i should break the loop when error happens right? Yes > > and i uploaded 2 version of patches, which one do you prefer to go on? Where to? Regards Oliver