From: Szymon Janc <szymon.janc@tieto.com>
To: Johan Hedberg <johan.hedberg@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v2] android/bluetooth: Fix discovering new devices
Date: Thu, 16 Jan 2014 15:50:36 +0100 [thread overview]
Message-ID: <1502325.Jt3PyHcn9k@uw000953> (raw)
In-Reply-To: <20140116135032.GA1267@x220.p-661hnu-f1>
Hi,
On Thursday 16 of January 2014 15:50:32 Johan Hedberg wrote:
> Hi Szymon,
>
> On Thu, Jan 16, 2014, Szymon Janc wrote:
> > @@ -983,12 +994,15 @@ static void update_found_device(const bdaddr_t *bdaddr, uint8_t bdaddr_type,
> > eir_parse(&eir, data, data_len);
> >
> > dev = find_device(bdaddr);
> > - if (!dev) {
> > + if (!dev || !dev->found) {
>
> I think this would still deserve a code comment here explaining why
> dev->found is important. Other than that the patch is fine, so feel free
> to push it yourself once you've added the comment.
Pushed.
--
Best regards,
Szymon Janc
prev parent reply other threads:[~2014-01-16 14:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-16 13:35 [PATCH v2] android/bluetooth: Fix discovering new devices Szymon Janc
2014-01-16 13:50 ` Johan Hedberg
2014-01-16 14:50 ` Szymon Janc [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1502325.Jt3PyHcn9k@uw000953 \
--to=szymon.janc@tieto.com \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox