From: Bastien Nocera <hadess@hadess.net>
To: Szymon Janc <szymon.janc@codecoup.pl>
Cc: Bluez mailing list <linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH 4/9] plugins/sixaxis: Move device discovery to shared header
Date: Tue, 05 Sep 2017 12:37:46 +0200 [thread overview]
Message-ID: <1504607866.6911.1.camel@hadess.net> (raw)
In-Reply-To: <CAAEJBhJpr_shNrShELVqATj3aiPQTV+saTY=cDXetYn87PQghw@mail.gmail.com>
On Tue, 2017-09-05 at 11:13 +0200, Szymon Janc wrote:
> Hi Bastien,
>
> On 5 September 2017 at 11:03, Bastien Nocera <hadess@hadess.net>
> wrote:
> > On Mon, 2017-09-04 at 20:12 +0200, Bastien Nocera wrote:
> > > <snip>
> > > +
> > > +inline CablePairingType
> > > +get_pairing_type(uint16_t vid,
> > > + uint16_t pid,
> > > + char **name,
> > > + uint16_t *source,
> > > + uint16_t *version)
> >
> > I have a slightly updated version of that section. "static" is
> > missing
> > in front of the inline function for use with RPM build's strict
> > linker
> > settings, and I'm sure the indentation police would like to see
> > that
> > function return type and name on the same line ;)
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-
> > bluetooth" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> I'm not sure why this is in header in first place ?
It should become clear if you look at the rest of the patchset.
As we discussed in Juha's version of this patchset, we want to share
this code between the sixaxis plugin, and the input profiles code. A
code header is the easiest way to do this without getting into build
conditionals.
next prev parent reply other threads:[~2017-09-05 10:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-04 18:12 [PATCH 1/9] plugins/sixaxis: Remove LEDs handling Bastien Nocera
2017-09-04 18:12 ` [PATCH 2/9] adapter: Add btd_request_authorization_cable_configured() Bastien Nocera
2017-09-04 18:12 ` [PATCH 3/9] sixaxis: Ask user whether cable configuration should be allowed Bastien Nocera
2017-09-27 9:12 ` Szymon Janc
2017-10-18 1:51 ` Bastien Nocera
2017-09-27 9:14 ` Szymon Janc
2017-10-04 12:38 ` Bastien Nocera
2017-09-04 18:12 ` [PATCH 4/9] plugins/sixaxis: Move device discovery to shared header Bastien Nocera
2017-09-05 9:03 ` Bastien Nocera
2017-09-05 9:13 ` Szymon Janc
2017-09-05 10:37 ` Bastien Nocera [this message]
2017-09-04 18:12 ` [PATCH 5/9] profiles/input: Use sixaxis header to simplify device detection Bastien Nocera
2017-09-04 18:12 ` [PATCH 6/9] profiles/input: Add DS4 devices to the shared header Bastien Nocera
2017-09-04 18:12 ` [PATCH 7/9] plugins/sixaxis: Rename sixaxis specific functions Bastien Nocera
2017-09-04 18:12 ` [PATCH 8/9] plugins/sixaxis: Add support for DualShock 4/PS4 cable pairing Bastien Nocera
2017-09-27 9:12 ` Szymon Janc
2017-10-04 12:40 ` Bastien Nocera
2017-10-18 1:51 ` Bastien Nocera
2017-09-04 18:12 ` [PATCH 9/9] plugins/sixaxis: Cancel cable pairing if unplugged Bastien Nocera
2017-09-27 9:07 ` [PATCH 1/9] plugins/sixaxis: Remove LEDs handling Szymon Janc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1504607866.6911.1.camel@hadess.net \
--to=hadess@hadess.net \
--cc=linux-bluetooth@vger.kernel.org \
--cc=szymon.janc@codecoup.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).