From: Szymon Janc <szymon.janc@tieto.com>
To: Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] android/core: Fix extra assignment
Date: Fri, 26 Sep 2014 11:54:02 +0200 [thread overview]
Message-ID: <1506993.bGXqPPn6y9@uw000953> (raw)
In-Reply-To: <1411719405-14321-1-git-send-email-Andrei.Emeltchenko.news@gmail.com>
Hi Andrei,
On Friday 26 of September 2014 11:16:45 Andrei Emeltchenko wrote:
> From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
>
> prop is assigned in the beginning of for() loop. Fixes warning:
> ...
> android/main.c:336:3: warning: Value stored to 'prop' is never read
> prop = buf;
> ^ ~~~
> ...
> ---
> android/main.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/android/main.c b/android/main.c
> index 663995e..2bc2dfe 100644
> --- a/android/main.c
> +++ b/android/main.c
> @@ -334,7 +334,6 @@ static void configuration(const void *buf, uint16_t len)
>
> buf += sizeof(*prop) + prop->len;
> len -= sizeof(*prop) + prop->len;
> - prop = buf;
> }
>
> ipc_send_rsp(hal_ipc, HAL_SERVICE_ID_CORE, HAL_OP_CONFIGURATION,
>
Applied, thanks.
--
Best regards,
Szymon Janc
prev parent reply other threads:[~2014-09-26 9:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-26 8:16 [PATCH] android/core: Fix extra assignment Andrei Emeltchenko
2014-09-26 9:54 ` Szymon Janc [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1506993.bGXqPPn6y9@uw000953 \
--to=szymon.janc@tieto.com \
--cc=Andrei.Emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox