linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tedd Ho-Jeong An <tedd.an@intel.com>
To: Johan Hedberg <johan.hedberg@intel.com>
Cc: Marcel Holtmann <marcel@holtmann.org>, linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] hciattach: Add support for Intel Bluetooth device
Date: Tue, 15 May 2012 10:26:40 -0700	[thread overview]
Message-ID: <1507913.3W6pHHIlAc@tedd-ubuntu> (raw)
In-Reply-To: <20120515074634.GA19482@x220>

Johan.

I just sent a patch via "git send-email". I hope this will work at this time.

Thanks.

Tedd

On Tuesday, May 15, 2012 10:46:34 AM Johan Hedberg wrote:
> Hi Marcel,
> 
> On Mon, May 14, 2012, Marcel Holtmann wrote:
> > > This patch enables the Intel Bluetooth device (UART sku) over the H4 protocol.
> > > It is responsible for bring up the device into known state by configuring
> > > the baudrate and applying the patches, if required.
> > > 
> > > ---
> > >  Makefile.tools          |    3 +-
> > >  tools/hciattach.8       |    3 +
> > >  tools/hciattach.c       |   13 ++
> > >  tools/hciattach.h       |    1 +
> > >  tools/hciattach_intel.c |  596 
> > > +++++++++++++++++++++++++++++++++++++++++++++++
> > >  5 files changed, 615 insertions(+), 1 deletion(-)
> > >  create mode 100644 tools/hciattach_intel.c
> > 
> > looks good to me.
> > 
> > Johan, feel free to apply this patch.
> 
> Looks ok to me too, except that it doesn't apply:
> 
> Applying: hciattach: Add support for Intel Bluetooth device
> fatal: corrupt patch at line 16
> Patch failed at 0001 hciattach: Add support for Intel Bluetooth device
> 
> As you can see even from the diffstat Tedd's email client is splitting
> long lines. Please try to use git send-email to resend or fix your mail
> client not to mangle the patch.
> 
> Johan
-- 
Regards
Tedd Ho-Jeong An
Intel Corporation

  parent reply	other threads:[~2012-05-15 17:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-15  0:16 [PATCH] hciattach: Add support for Intel Bluetooth device Tedd Ho-Jeong An
2012-05-15  1:23 ` Marcel Holtmann
2012-05-15  7:46   ` Johan Hedberg
2012-05-15 16:45     ` Tedd Ho-Jeong An
2012-05-15 17:26     ` Tedd Ho-Jeong An [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-05-15 17:23 Tedd Ho-Jeong An
2012-05-16  7:41 ` Johan Hedberg
2012-05-08 18:41 Tedd Ho-Jeong An
2012-05-14  2:52 ` Marcel Holtmann
2012-05-14 17:13   ` Tedd Ho-Jeong An
2012-05-08  5:13 Tedd Ho-Jeong An
2012-05-08 14:03 ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1507913.3W6pHHIlAc@tedd-ubuntu \
    --to=tedd.an@intel.com \
    --cc=johan.hedberg@intel.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=marcel@holtmann.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).