From: Bastien Nocera <hadess@hadess.net>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH] obex: Use GLib helper function to manipulate paths
Date: Fri, 24 Nov 2017 16:18:57 +0100 [thread overview]
Message-ID: <1511536737.11411.19.camel@hadess.net> (raw)
In-Reply-To: <CABBYNZKfZ7mjUsQP+rLRE+RWF8WrYvV6OUvTi5hEaR4AujkmNA@mail.gmail.com>
On Fri, 2017-11-24 at 17:12 +0200, Luiz Augusto von Dentz wrote:
> Hi Bastien,
>
> On Fri, Nov 24, 2017 at 4:12 PM, Bastien Nocera <hadess@hadess.net>
> wrote:
> > On Sat, 2013-11-09 at 18:18 +0100, Bastien Nocera wrote:
> > > Instead of trying to do it by hand. This also makes sure that
> > > relative paths aren't used by the agent.
> >
> > This is still relevant and applicable.
>
> Id leave as it is if that is not causing any bugs, we do intend to
> move away from glib at some point.
I'm pretty sure that the existing code isn't secure and passing a
relative path as the name will make it break out of the expected
destination folder.
prev parent reply other threads:[~2017-11-24 15:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-09 17:18 [PATCH] obex: Use GLib helper function to manipulate paths Bastien Nocera
2017-11-24 14:12 ` Bastien Nocera
2017-11-24 15:12 ` Luiz Augusto von Dentz
2017-11-24 15:18 ` Bastien Nocera [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1511536737.11411.19.camel@hadess.net \
--to=hadess@hadess.net \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).