linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steve Brown <sbrown@cortland.com>
To: "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Cc: Steve Brown <sbrown@cortland.com>
Subject: Re: meshctl: publish db entry malformed for 2d model of an element
Date: Fri, 15 Dec 2017 04:14:48 -0700	[thread overview]
Message-ID: <1513336488.18172.20.camel@ewol.com> (raw)
In-Reply-To: <1513293681.4409.12.camel@ewol.com>

On Thu, 2017-12-14 at 16:21 -0700, Steve Brown wrote:
> The entries for the second model of an element appear malformed.
> 
> This with the current head (813b8e6737ba0c43255979b09a089c44b757a556)
> 
> The commands were:
> 
> add-appkey 1
> bind 0 1 1000
> bind 0 1 1001
> set-pub 0100 c000 1 0 1001
> set-pub 0100 c000 1 0 1000
> back
> mesh-info
> 
> Steve
> 
>         "elements":[
>           {
>             "elementIndex":0,
>             "unicastAddress":"0100",
>             "models":[
>               {
>                 "modelId":"1000",
>                 "bind":[
>                   1
>                 ],
>                 "publish":{
>                   "address":"c000",
>                   "index":"0001",
>                   "ttl":255
>                 }
>               },
>               {
>                 "modelId":"1001",
>                 "bind":[
>                   1
>                 ]
>               },
>               {
>                 "modelId":"1001",
>                 "publish":{
>                   "address":"c000",
>                   "index":"0001",
>                   "ttl":255
>                 }
>               }
>             ]
>           },
>           {

The calling sequence is

prov_db_node_set_model_pub()
  get_jmodel_obj()
    parse_configuration_models()
    
There seems to be a problem in parse_configuration_models(). In the
loop looking for the model that matches the target_id, if the first
model matches, the model object is returned and the function exits.

If the loop has to iterate, it next calls parse_bindings(). That
function looks to see if the binding already exists and because it
does, exits false with jmodel set to null.

The consequence is the addition of a second modelId object for the same
 model id.

I'm not familiar with the code and am not sure how to fix this.

Steve




      reply	other threads:[~2017-12-15 11:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-14 23:21 meshctl: publish db entry malformed for 2d model of an element Steve Brown
2017-12-15 11:14 ` Steve Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1513336488.18172.20.camel@ewol.com \
    --to=sbrown@cortland.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).