From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Lukas Wunner <lukas@wunner.de>,
Marcel Holtmann <marcel@holtmann.org>,
Johan Hedberg <johan.hedberg@gmail.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
Frederic Danis <frederic.danis.oss@gmail.com>,
Loic Poulain <loic.poulain@linaro.org>,
Hans de Goede <hdegoede@redhat.com>, Max Shavrick <mxms@me.com>,
Leif Liddy <leif.liddy@gmail.com>,
Daniel Roschka <danielroschka@phoenitydawn.de>,
Ronald Tschalaer <ronald@innovation.ch>,
"Peter Y. Chuang" <peteryuchuang@gmail.com>,
linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v2 05/10] Bluetooth: hci_bcm: Add helper to toggle device wake GPIO
Date: Wed, 03 Jan 2018 15:06:14 +0200 [thread overview]
Message-ID: <1514984774.7000.569.camel@linux.intel.com> (raw)
In-Reply-To: <5f656f915ada50079fd5606ee591e59239ab6a2b.1514916630.git.lukas@wunner.de>
On Tue, 2018-01-02 at 20:08 +0100, Lukas Wunner wrote:
> There is already a bcm_gpio_set_power() helper to toggle the power
> enable pin. Add a corresponding helper to toggle the device wake pin.
> This will allow us to more easily integrate support for MacBooks which
> use custom ACPI methods to access both pins.
>
> The only functional change here is an additional 15 ms delay when
> toggling the device wake pin in bcm_gpio_set_power(). It is unclear
> why
> this delay is observed in bcm_suspend_device() and
> bcm_resume_device(),
> but not in bcm_gpio_set_power() so far.
Btw, can we switch to msleep() ?
I don't check if it's atomic context when it's used.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2018-01-03 13:06 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-02 19:08 [PATCH v2 00/10] Bluetooth on 2015+ MacBook (Pro) Lukas Wunner
2018-01-02 19:08 ` [PATCH v2 07/10] Bluetooth: hci_bcm: Clean up unnecessary #ifdef Lukas Wunner
2018-01-02 19:08 ` [PATCH v2 06/10] Bluetooth: hci_bcm: Silence IRQ printk Lukas Wunner
2018-01-03 13:08 ` Andy Shevchenko
2018-01-03 13:56 ` Lukas Wunner
2018-01-03 16:05 ` Andy Shevchenko
2018-01-02 19:08 ` [PATCH v2 04/10] Bluetooth: hci_bcm: Validate IRQ before using it Lukas Wunner
2018-01-02 19:08 ` [PATCH v2 08/10] Bluetooth: hci_bcm: Document struct bcm_device Lukas Wunner
2018-01-02 19:08 ` [PATCH v2 02/10] Bluetooth: hci_bcm: Mandate presence of shutdown and device wake GPIO Lukas Wunner
2018-01-03 12:55 ` Marcel Holtmann
2018-01-02 19:08 ` [PATCH v2 09/10] Bluetooth: hci_bcm: Handle errors properly Lukas Wunner
2018-01-03 16:08 ` Andy Shevchenko
2018-01-03 18:54 ` Lukas Wunner
2018-01-03 19:08 ` Andy Shevchenko
2018-01-02 19:08 ` [PATCH v2 01/10] Bluetooth: Depend on rather than select GPIOLIB Lukas Wunner
2018-01-03 7:52 ` Linus Walleij
2018-01-05 18:27 ` Marcel Holtmann
2018-01-02 19:08 ` [PATCH v2 05/10] Bluetooth: hci_bcm: Add helper to toggle device wake GPIO Lukas Wunner
2018-01-03 13:06 ` Andy Shevchenko [this message]
2018-01-02 19:08 ` [PATCH v2 03/10] Bluetooth: hci_bcm: Enable runtime PM despite absence of IRQ Lukas Wunner
2018-01-02 19:17 ` Hans de Goede
2018-01-02 23:36 ` Lukas Wunner
2018-01-03 8:07 ` Hans de Goede
2018-01-03 13:34 ` Lukas Wunner
2018-01-03 12:34 ` Marcel Holtmann
2018-01-03 13:22 ` Lukas Wunner
2018-01-03 13:29 ` Marcel Holtmann
2018-01-03 13:34 ` Lukas Wunner
2018-01-02 19:08 ` [PATCH v2 10/10] Bluetooth: hci_bcm: Support Apple GPIO handling Lukas Wunner
2018-01-03 12:55 ` Marcel Holtmann
2018-01-03 16:12 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1514984774.7000.569.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=danielroschka@phoenitydawn.de \
--cc=frederic.danis.oss@gmail.com \
--cc=hdegoede@redhat.com \
--cc=johan.hedberg@gmail.com \
--cc=leif.liddy@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=lukas@wunner.de \
--cc=marcel@holtmann.org \
--cc=mika.westerberg@linux.intel.com \
--cc=mxms@me.com \
--cc=peteryuchuang@gmail.com \
--cc=ronald@innovation.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).