Re: [PATCH v3 00/13] Bluetooth on 2015+ MacBook (Pro)

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

On Sun, 2018-01-07 at 20:16 +0100, Lukas Wunner wrote:
> Enable UART-attached Bluetooth on 2015+ Macs, v3.
> 
> The series has grown to 13 patches because bugs in the driver keep
> cropping up.
> 
> Changes since v2:
> 
> - In patch [01/13] ("Mandate presence of shutdown and device wake
> GPIO"):
>   Keep netdev indentation style. (Marcel)
> 
> - New patch [04/13] to fix an IRQ race on ->close.
> 
> - New patch [05/13] to fix an unbalanced pm_runtime_disable(). (Andy)
> 
> - New patch [06/13] to invalidate the IRQ if requesting it failed.
> 
> - New patch [08/13] to add callbacks to toggle GPIOs.
>   This makes the subsequent addition of Mac support less intrusive.
>   Replaces patch "Add helper to toggle device wake GPIO" in v2. (Andy)
> 
> - In patch [09/13] ("Handle errors properly"):
>   Drop redundant assignment. (Andy)
> 
> - In patch [10/13] ("Support Apple GPIO handling"):
>   Don't enable runtime PM on Macs for lack of usable host wake IRQ
> (Hans),
>   s/BlueTooth/Bluetooth/ in kerneldoc. (Marcel)
> 
> - Move patch "Silence IRQ printk" to end of series as it's merely
>   a cleanup and no longer necessary for Mac support.
> 
> - New patch [12/13] to use msleep() instead of mdelay()
>   after toggling device wake pin. (Andy)
> 
> - New patch [13/13] to fix sleep mode struct ordering.
> 
> - Drop incorrect patch "Enable runtime PM despite absence of IRQ".
> (Hans)
> 

I didn't test this myself (yet), the code looks more or less fine to me,
 FWIW, 

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

> Link to v2:
> https://marc.info/?l=linux-bluetooth&m=151492012812029&w=4
> 
> Thanks,
> 
> Lukas
> 
> 
> Lukas Wunner (12):
>   Bluetooth: hci_bcm: Mandate presence of shutdown and device wake
> GPIO
>   Bluetooth: hci_bcm: Clean up unnecessary #ifdef
>   Bluetooth: hci_bcm: Fix race on close
>   Bluetooth: hci_bcm: Fix unbalanced pm_runtime_disable()
>   Bluetooth: hci_bcm: Invalidate IRQ on request failure
>   Bluetooth: hci_bcm: Document struct bcm_device
>   Bluetooth: hci_bcm: Add callbacks to toggle GPIOs
>   Bluetooth: hci_bcm: Handle errors properly
>   Bluetooth: hci_bcm: Support Apple GPIO handling
>   Bluetooth: hci_bcm: Silence IRQ printk
>   Bluetooth: hci_bcm: Sleep instead of spinning
>   Bluetooth: btbcm: Fix sleep mode struct ordering
> 
> Ronald Tschalär (1):
>   Bluetooth: hci_bcm: Validate IRQ before using it
> 
>  drivers/bluetooth/btbcm.h   |   2 +-
>  drivers/bluetooth/hci_bcm.c | 227
> ++++++++++++++++++++++++++++++++++++--------
>  2 files changed, 189 insertions(+), 40 deletions(-)
> 

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy