From: Szymon Janc <szymon.janc@tieto.com>
To: Ian Coolidge <icoolidge@google.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] android/log: Add missing libc includes.
Date: Mon, 02 Feb 2015 12:50:25 +0100 [thread overview]
Message-ID: <1527070.LF3VyE4bnx@uw000953> (raw)
In-Reply-To: <1422866028-10696-1-git-send-email-icoolidge@google.com>
Hi Ian,
On Monday 02 of February 2015 00:33:48 Ian Coolidge wrote:
> ---
> android/log.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/android/log.c b/android/log.c
> index 09d226a..8013eba 100644
> --- a/android/log.c
> +++ b/android/log.c
> @@ -25,7 +25,10 @@
> #endif
>
> #include <fcntl.h>
> +#include <stdarg.h>
> #include <stdio.h>
> +#include <stdint.h>
> +#include <stdlib.h>
> #include <unistd.h>
> #include <stdbool.h>
> #include <time.h>
Could you add some explanation to commit message why those are needed?
--
Best regards,
Szymon Janc
next prev parent reply other threads:[~2015-02-02 11:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-02 8:33 [PATCH] android/log: Add missing libc includes Ian Coolidge
2015-02-02 11:50 ` Szymon Janc [this message]
2015-02-02 19:10 ` [PATCH v2] " Ian Coolidge
2015-02-03 9:54 ` Szymon Janc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1527070.LF3VyE4bnx@uw000953 \
--to=szymon.janc@tieto.com \
--cc=icoolidge@google.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox