From: Jaganath Kanakkassery <jaganath.k.os@gmail.com>
To: linux-bluetooth@vger.kernel.org
Cc: marcel@holtmann.org,
Jaganath Kanakkassery <jaganathx.kanakkassery@intel.com>
Subject: [PATCH v5 01/16] Bluetooth: Define PHY flags in hdev and set 1M as default
Date: Thu, 19 Jul 2018 17:09:32 +0530 [thread overview]
Message-ID: <1532000387-3649-2-git-send-email-jaganathx.kanakkassery@intel.com> (raw)
In-Reply-To: <1532000387-3649-1-git-send-email-jaganathx.kanakkassery@intel.com>
1M is mandatory to be supported by LE controllers and the same
would be set in power on. This patch defines hdev flags for
LE PHYs and set 1M to default.
Signed-off-by: Jaganath Kanakkassery <jaganathx.kanakkassery@intel.com>
---
include/net/bluetooth/hci.h | 4 ++++
include/net/bluetooth/hci_core.h | 3 +++
net/bluetooth/hci_core.c | 9 +++++----
3 files changed, 12 insertions(+), 4 deletions(-)
diff --git a/include/net/bluetooth/hci.h b/include/net/bluetooth/hci.h
index 73e48be..664fe1e 100644
--- a/include/net/bluetooth/hci.h
+++ b/include/net/bluetooth/hci.h
@@ -1514,6 +1514,10 @@ struct hci_cp_le_set_default_phy {
__u8 rx_phys;
} __packed;
+#define HCI_LE_SET_PHY_1M 0x01
+#define HCI_LE_SET_PHY_2M 0x02
+#define HCI_LE_SET_PHY_CODED 0x04
+
#define HCI_OP_LE_SET_EXT_SCAN_PARAMS 0x2041
struct hci_cp_le_set_ext_scan_params {
__u8 own_addr_type;
diff --git a/include/net/bluetooth/hci_core.h b/include/net/bluetooth/hci_core.h
index a744535..71f79df 100644
--- a/include/net/bluetooth/hci_core.h
+++ b/include/net/bluetooth/hci_core.h
@@ -315,6 +315,9 @@ struct hci_dev {
unsigned long sco_last_tx;
unsigned long le_last_tx;
+ __u8 le_tx_def_phys;
+ __u8 le_rx_def_phys;
+
struct workqueue_struct *workqueue;
struct workqueue_struct *req_workqueue;
diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c
index f5c21004..432f89f 100644
--- a/net/bluetooth/hci_core.c
+++ b/net/bluetooth/hci_core.c
@@ -830,10 +830,9 @@ static int hci_init4_req(struct hci_request *req, unsigned long opt)
if (hdev->commands[35] & 0x20) {
struct hci_cp_le_set_default_phy cp;
- /* No transmitter PHY or receiver PHY preferences */
- cp.all_phys = 0x03;
- cp.tx_phys = 0;
- cp.rx_phys = 0;
+ cp.all_phys = 0x00;
+ cp.tx_phys = hdev->le_tx_def_phys;
+ cp.rx_phys = hdev->le_rx_def_phys;
hci_req_add(req, HCI_OP_LE_SET_DEFAULT_PHY, sizeof(cp), &cp);
}
@@ -3027,6 +3026,8 @@ struct hci_dev *hci_alloc_dev(void)
hdev->le_max_tx_time = 0x0148;
hdev->le_max_rx_len = 0x001b;
hdev->le_max_rx_time = 0x0148;
+ hdev->le_tx_def_phys = HCI_LE_SET_PHY_1M;
+ hdev->le_rx_def_phys = HCI_LE_SET_PHY_1M;
hdev->rpa_timeout = HCI_DEFAULT_RPA_TIMEOUT;
hdev->discov_interleaved_timeout = DISCOV_INTERLEAVED_TIMEOUT;
--
2.7.4
next prev parent reply other threads:[~2018-07-19 11:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-19 11:39 [PATCH v5 00/16] Bluetooth: Extended Adv, Scan, Connection and PHY support Jaganath Kanakkassery
2018-07-19 11:39 ` Jaganath Kanakkassery [this message]
2018-07-19 11:39 ` [PATCH v5 02/16] Bluetooth: Add defines for BREDR pkt_type and LE PHYs Jaganath Kanakkassery
2018-07-19 11:39 ` [PATCH v5 03/16] Bluetooth: Implement Get PHY Configuration mgmt command Jaganath Kanakkassery
2018-07-19 11:39 ` [PATCH v5 04/16] Bluetooth: Implement Set PHY Confguration command Jaganath Kanakkassery
2018-07-19 11:39 ` [PATCH v5 05/16] Bluetooth: Implement PHY changed event Jaganath Kanakkassery
2018-07-19 11:39 ` [PATCH v5 06/16] Bluetooth: Set Scan PHYs based on selected PHYs by user Jaganath Kanakkassery
2018-07-19 11:39 ` [PATCH v5 07/16] Bluetooth: Handle extended ADV PDU types Jaganath Kanakkassery
2018-07-19 11:39 ` [PATCH v5 08/16] Bluetooth: Use selected PHYs in extended connect Jaganath Kanakkassery
2018-07-19 11:39 ` [PATCH v5 09/16] Bluetooth: Read no of adv sets during init Jaganath Kanakkassery
2018-07-19 11:39 ` [PATCH v5 10/16] Bluetooth: Impmlement extended adv enable Jaganath Kanakkassery
2018-07-19 11:39 ` [PATCH v5 11/16] Bluetooth: Use Set ext adv/scan rsp data if controller supports Jaganath Kanakkassery
2018-07-19 11:39 ` [PATCH v5 12/16] Bluetooth: Implement disable and removal of adv instance Jaganath Kanakkassery
2018-07-19 11:39 ` [PATCH v5 13/16] Bluetooth: Use ext adv for directed adv Jaganath Kanakkassery
2018-07-19 11:39 ` [PATCH v5 14/16] Bluetooth: Implement Set ADV set random address Jaganath Kanakkassery
2018-07-19 11:39 ` [PATCH v5 15/16] Bluetooth: Handle ADv set terminated event Jaganath Kanakkassery
2018-07-19 11:39 ` [PATCH v5 16/16] Bluetooth: Implement secondary advertising on different PHYs Jaganath Kanakkassery
2018-07-30 11:58 ` [PATCH v5 00/16] Bluetooth: Extended Adv, Scan, Connection and PHY support Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1532000387-3649-2-git-send-email-jaganathx.kanakkassery@intel.com \
--to=jaganath.k.os@gmail.com \
--cc=jaganathx.kanakkassery@intel.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).