linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Gopal Tiwari <gtiwari@redhat.com>
To: linux-bluetooth@vger.kernel.org
Cc: dzickus@redhat.com, gtiwari@redhat.com
Subject: [PATCH BlueZ 1/2] Fixing possible use_after_free.
Date: Fri, 20 Jul 2018 10:03:58 +0530	[thread overview]
Message-ID: <1532061239-22481-1-git-send-email-gtiwari@redhat.com> (raw)

During the code review of code. Found some of the possible
double free scenario's. So fixing them.
---
 gobex/gobex-transfer.c | 6 ++++++
 obexd/client/session.c | 6 +++++-
 tools/mesh/prov-db.c   | 4 +++-
 3 files changed, 14 insertions(+), 2 deletions(-)

diff --git a/gobex/gobex-transfer.c b/gobex/gobex-transfer.c
index bc99306..11980d0 100644
--- a/gobex/gobex-transfer.c
+++ b/gobex/gobex-transfer.c
@@ -428,6 +428,12 @@ guint g_obex_put_rsp(GObex *obex, GObexPacket *req,
 	va_start(args, first_hdr_id);
 	transfer_put_req_first(transfer, req, first_hdr_id, args);
 	va_end(args);
+
+	/* Checking transfer in case transfer_put_req_first has
+	 * freed it to avoid double free */
+	if(!transfer)
+		return 0;
+
 	if (!g_slist_find(transfers, transfer))
 		return 0;
 
diff --git a/obexd/client/session.c b/obexd/client/session.c
index 5bd2d26..077224b 100644
--- a/obexd/client/session.c
+++ b/obexd/client/session.c
@@ -938,7 +938,11 @@ static void session_terminate_transfer(struct obc_session *session,
 	if (session->p == NULL)
 		session_process_queue(session);
 
-	obc_session_unref(session);
+	/* Verifying the session variable for double free
+	 */
+
+	if (session)
+		obc_session_unref(session);
 }
 
 static void session_notify_complete(struct obc_session *session,
diff --git a/tools/mesh/prov-db.c b/tools/mesh/prov-db.c
index 05b2547..74915d2 100644
--- a/tools/mesh/prov-db.c
+++ b/tools/mesh/prov-db.c
@@ -876,8 +876,10 @@ bool prov_db_local_set_iv_index(uint32_t iv_index, bool update, bool prov)
 
 	res = true;
 done:
+	/* Varify in_str for double free */
 
-	g_free(in_str);
+	if(in_str)
+		g_free(in_str);
 
 	if(jmain)
 		json_object_put(jmain);
-- 
2.7.5


             reply	other threads:[~2018-07-20  4:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-20  4:33 Gopal Tiwari [this message]
2018-07-20  4:33 ` [PATCH BlueZ 2/2] Possible bug fix nsk replaced with sk Gopal Tiwari
2018-07-20  8:24 ` [PATCH BlueZ 1/2] Fixing possible use_after_free Luiz Augusto von Dentz
2018-07-23  6:28   ` Gopal Tiwari
2018-07-23  8:49     ` Luiz Augusto von Dentz
2018-07-23  9:06       ` Gopal Tiwari
2018-07-23 14:25       ` Don Zickus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1532061239-22481-1-git-send-email-gtiwari@redhat.com \
    --to=gtiwari@redhat.com \
    --cc=dzickus@redhat.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).