From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Szymon Janc To: linux-bluetooth@vger.kernel.org Subject: Re: [PATCH 0/5] android: Pairing improvements Date: Mon, 19 May 2014 10:18:53 +0200 Message-ID: <1554296.3VRD4VHHxv@uw000953> In-Reply-To: <1400414040-30913-1-git-send-email-szymon.janc@tieto.com> References: <1400414040-30913-1-git-send-email-szymon.janc@tieto.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Sender: linux-bluetooth-owner@vger.kernel.org List-ID: On Sunday 18 of May 2014 13:53:55 Szymon Janc wrote: > Hi, > > This improves (fix) the way dual mode devices are handled. Bearer type is > now tracked and allows to use correct one for dual mode device. > > This also adds tracking if remote device was bonded or not. This is in > preparation for fixing no bond pairing. Android HAL does not distinguish > between pairing and bonding and appears to be ignoring bond state change > bonded->no_bond from stack. This leads to situation when device is no longer > paired (after being disconnected) but still being listed as bonded in > Android Framework. Possible solution would be to not call bond_state change > to bonded for no bond case (this seems to be what Bluedroid is doing [1]) > but this still needs further analyze and testing. > > BR > Szymon Janc > > > [1] http://androidxref.com/4.4.2_r1/xref/external/bluetooth/bluedroid/btif/src/btif_dm.c#338 > > Szymon Janc (5): > android/bluetooth: Track device last connected bearer > android/bluetooth: Fix pairing of dual mode devices > android/bluetooth: Fix unpairing dual mode device > android/bluetooth: Track if paired device is bonded > android/bluetooth: Simplify check if device type changed > > android/bluetooth.c | 315 ++++++++++++++++++++++++++++++++++++++-------------- > 1 file changed, 233 insertions(+), 82 deletions(-) > > Pushed. -- Best regards, Szymon Janc