From: Szymon Janc <szymon.janc@tieto.com>
To: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v3] emulator/hciemu: Fix not handling failed read correctly
Date: Mon, 29 Sep 2014 10:27:37 +0200 [thread overview]
Message-ID: <1560201.dnxDJYBh5A@uw000953> (raw)
In-Reply-To: <1411655558-18167-1-git-send-email-szymon.janc@tieto.com>
On Thursday 25 of September 2014 16:32:38 Szymon Janc wrote:
> If read failed due to signal or blocking watch was removed resulting
> in closing /dev/vhci and emulated adapter being removed.
>
> This was affecting android-tester since premature removal of adapter
> is considered error on android daemon.
> ---
> emulator/hciemu.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/emulator/hciemu.c b/emulator/hciemu.c
> index 50285e4..fcaeb70 100644
> --- a/emulator/hciemu.c
> +++ b/emulator/hciemu.c
> @@ -179,6 +179,13 @@ static gboolean receive_btdev(GIOChannel *channel, GIOCondition condition,
> fd = g_io_channel_unix_get_fd(channel);
>
> len = read(fd, buf, sizeof(buf));
> + if (len < 0) {
> + if (errno == EAGAIN || errno == EINTR)
> + return TRUE;
> +
> + return FALSE;
> + }
> +
> if (len < 1)
> return FALSE;
>
>
Applied.
--
Best regards,
Szymon Janc
prev parent reply other threads:[~2014-09-29 8:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-25 14:32 [PATCH v3] emulator/hciemu: Fix not handling failed read correctly Szymon Janc
2014-09-29 8:27 ` Szymon Janc [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1560201.dnxDJYBh5A@uw000953 \
--to=szymon.janc@tieto.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox