From: "Gix, Brian" <brian.gix@intel.com>
To: "michal.lowas-rzechonek@silvair.com"
<michal.lowas-rzechonek@silvair.com>,
"linux-bluetooth@vger.kernel.org"
<linux-bluetooth@vger.kernel.org>
Cc: "michal@rzechonek.net" <michal@rzechonek.net>
Subject: Re: [PATCH BlueZ] mesh: Fix stack overflow in get_element_properties
Date: Thu, 4 Jul 2019 00:16:05 +0000 [thread overview]
Message-ID: <1562199362.23933.38.camel@intel.com> (raw)
In-Reply-To: <20190703190833.22039-1-michal.lowas-rzechonek@silvair.com>
Applied
On Wed, 2019-07-03 at 21:08 +0200, Michał Lowas-Rzechonek wrote:
> From: Michał 'Khorne' Lowas-Rzechonek <michal@rzechonek.net>
>
> D-Bus type 'q' denotes uint16, not uint8.
> ---
> mesh/node.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mesh/node.c b/mesh/node.c
> index c73ba541f..f9be96cbd 100644
> --- a/mesh/node.c
> +++ b/mesh/node.c
> @@ -1200,7 +1200,7 @@ static bool get_element_properties(struct mesh_node *node, const char *path,
>
> while (l_dbus_message_iter_next_entry(properties, &key, &var)) {
> if (!strcmp(key, "Location")) {
> - uint8_t loc;
> + uint16_t loc;
>
> l_dbus_message_iter_get_variant(&var, "q", &loc);
>
prev parent reply other threads:[~2019-07-04 0:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-03 19:08 [PATCH BlueZ] mesh: Fix stack overflow in get_element_properties Michał Lowas-Rzechonek
2019-07-04 0:16 ` Gix, Brian [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1562199362.23933.38.camel@intel.com \
--to=brian.gix@intel.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=michal.lowas-rzechonek@silvair.com \
--cc=michal@rzechonek.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).