From: Szymon Janc <szymon.janc@tieto.com>
To: Mariusz Skamra <mariusz.skamra@tieto.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCHv3] android/hidhost: Fix connecting HOGP over BREDR
Date: Fri, 22 May 2015 15:17:04 +0200 [thread overview]
Message-ID: <1614758.WFjxB6mBNu@leonov> (raw)
In-Reply-To: <1432115799-30849-1-git-send-email-mariusz.skamra@tieto.com>
Hi Mariusz,
On Wednesday 20 of May 2015 11:56:39 Mariusz Skamra wrote:
> This patch fixes issue related to HID connection over BREDR.
> To avoid HOG connection with dual mode device connected over
> BREDR, bearer type is checked not the features of remote device.
> ---
> android/hidhost.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/android/hidhost.c b/android/hidhost.c
> index 729b884..a2b820f 100644
> --- a/android/hidhost.c
> +++ b/android/hidhost.c
> @@ -891,7 +891,7 @@ static void bt_hid_connect(const void *buf, uint16_t
> len) ba2str(&dev->dst, addr);
> DBG("connecting to %s", addr);
>
> - if (bt_is_device_le(&dst)) {
> + if (bt_device_last_seen_bearer(&dev->dst) != BDADDR_BREDR) {
> if (!hog_connect(dev)) {
> status = HAL_STATUS_FAILED;
> hid_device_remove(dev);
Patch applied, thanks.
--
BR
Szymon Janc
prev parent reply other threads:[~2015-05-22 13:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-19 8:25 [PATCH] android/hidhost: Fix connecting HOGP over BREDR Mariusz Skamra
2015-05-19 8:56 ` [PATCHv2] " Mariusz Skamra
2015-05-19 14:09 ` Szymon Janc
2015-05-20 9:55 ` [PATCHv2] android/pts: Update SM test results Mariusz Skamra
2015-05-22 13:13 ` Szymon Janc
2015-05-20 9:56 ` [PATCHv3] android/hidhost: Fix connecting HOGP over BREDR Mariusz Skamra
2015-05-22 13:17 ` Szymon Janc [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1614758.WFjxB6mBNu@leonov \
--to=szymon.janc@tieto.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=mariusz.skamra@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).