Linux bluetooth development
 help / color / mirror / Atom feed
From: Szymon Janc <szymon.janc@tieto.com>
To: Jakub Tyszkowski <jakub.tyszkowski@tieto.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/2] android/gatt: Set proper primary flag for sending characteristics
Date: Fri, 11 Apr 2014 16:17:30 +0200	[thread overview]
Message-ID: <1619050.hvZinmgAR9@uw000953> (raw)
In-Reply-To: <1397220026-27177-1-git-send-email-jakub.tyszkowski@tieto.com>

Hi Jakub,

On Friday 11 of April 2014 14:40:25 Jakub Tyszkowski wrote:
> Fix sending included service's characteristics.
> ---
>  android/gatt.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/android/gatt.c b/android/gatt.c
> index aa2a5fd..13ae340 100644
> --- a/android/gatt.c
> +++ b/android/gatt.c
> @@ -1510,8 +1510,7 @@ static void send_client_char_notify(const struct characteristic *ch,
>  	}
>  
>  	ev.conn_id = conn_id;
> -	/* TODO need to be handled for included services too */
> -	element_id_to_hal_srvc_id(&service->id, 1, &ev.srvc_id);
> +	element_id_to_hal_srvc_id(&service->id, service->primary, &ev.srvc_id);
>  
>  	ipc_send_notif(hal_ipc, HAL_SERVICE_ID_GATT,
>  					HAL_EV_GATT_CLIENT_GET_CHARACTERISTIC,
> 

Both patches applied, thanks.

-- 
Best regards, 
Szymon Janc

      parent reply	other threads:[~2014-04-11 14:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-11 12:40 [PATCH 1/2] android/gatt: Set proper primary flag for sending characteristics Jakub Tyszkowski
2014-04-11 12:40 ` [PATCH 2/2] android/client: Fix parameter completion for gatt Jakub Tyszkowski
2014-04-11 14:17 ` Szymon Janc [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1619050.hvZinmgAR9@uw000953 \
    --to=szymon.janc@tieto.com \
    --cc=jakub.tyszkowski@tieto.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox