Linux bluetooth development
 help / color / mirror / Atom feed
From: Szymon Janc <szymon.janc@tieto.com>
To: Jakub Tyszkowski <jakub.tyszkowski@tieto.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 3/3] android/gatt: Send app uuid also for failure response
Date: Mon, 28 Apr 2014 18:00:01 +0200	[thread overview]
Message-ID: <1646919.8iKBmNv117@uw000953> (raw)
In-Reply-To: <1398691070-25530-3-git-send-email-jakub.tyszkowski@tieto.com>

Hi Jakub,

On Monday 28 of April 2014 15:17:50 Jakub Tyszkowski wrote:
> Framework should know which request failed.
> ---
>  android/gatt.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/android/gatt.c b/android/gatt.c
> index 7c59e12..a7b8659 100644
> --- a/android/gatt.c
> +++ b/android/gatt.c
> @@ -3105,7 +3105,6 @@ static void handle_server_register(const void *buf, uint16_t len)
>  
>  	ev.status = GATT_SUCCESS;
>  	ev.server_if = server->id;
> -	memcpy(ev.uuid, server->uuid, sizeof(server->uuid));
>  
>  	status = HAL_STATUS_SUCCESS;
>  
> @@ -3113,6 +3112,8 @@ failed:
>  	if (status != HAL_STATUS_SUCCESS)
>  		ev.status = GATT_FAILURE;
>  
> +	memcpy(ev.uuid, cmd->uuid, sizeof(ev.uuid));
> +
>  	ipc_send_notif(hal_ipc, HAL_SERVICE_ID_GATT,
>  				HAL_EV_GATT_SERVER_REGISTER, sizeof(ev), &ev);
>  
This patch is now pushed, thanks.

-- 
Best regards, 
Szymon Janc

      reply	other threads:[~2014-04-28 16:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-28 13:17 [PATCH 1/3] android/gatt: Add DEVICE_CONNECTING state Jakub Tyszkowski
2014-04-28 13:17 ` [PATCH 2/3] android/gatt Refactor le device connecting Jakub Tyszkowski
2014-04-28 13:17 ` [PATCH 3/3] android/gatt: Send app uuid also for failure response Jakub Tyszkowski
2014-04-28 16:00   ` Szymon Janc [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1646919.8iKBmNv117@uw000953 \
    --to=szymon.janc@tieto.com \
    --cc=jakub.tyszkowski@tieto.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox