From: Szymon Janc <szymon.janc@tieto.com>
To: Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] android/hidhost: Fix logical vs bitwise operation
Date: Mon, 24 Nov 2014 14:43:56 +0100 [thread overview]
Message-ID: <1655880.h1bZlBjNmq@leonov> (raw)
In-Reply-To: <1416563330-13822-1-git-send-email-Andrei.Emeltchenko.news@gmail.com>
Hi Andrei,
On Friday 21 of November 2014 11:48:50 Andrei Emeltchenko wrote:
> From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
>
> "buf[0] & !1" is always 0, should be bitwise operation.
> ---
> android/hidhost.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/android/hidhost.c b/android/hidhost.c
> index 75e895b..b696563 100644
> --- a/android/hidhost.c
> +++ b/android/hidhost.c
> @@ -465,7 +465,7 @@ static gboolean ctrl_io_watch_cb(GIOChannel *chan,
> gpointer data) bt_hid_notify_handshake(dev, buf, bread);
> break;
> case HID_MSG_CONTROL:
> - if ((buf[0] & !HID_MSG_TYPE_MASK) == HID_VIRTUAL_CABLE_UNPLUG)
> + if ((buf[0] & ~HID_MSG_TYPE_MASK) == HID_VIRTUAL_CABLE_UNPLUG)
> bt_hid_notify_virtual_unplug(dev, buf, bread);
> break;
> default:
Applied, thanks.
--
BR
Szymon Janc
prev parent reply other threads:[~2014-11-24 13:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-21 9:48 [PATCH] android/hidhost: Fix logical vs bitwise operation Andrei Emeltchenko
2014-11-24 13:43 ` Szymon Janc [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1655880.h1bZlBjNmq@leonov \
--to=szymon.janc@tieto.com \
--cc=Andrei.Emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox