* [PATCH] android/hidhost: Fix logical vs bitwise operation
@ 2014-11-21 9:48 Andrei Emeltchenko
2014-11-24 13:43 ` Szymon Janc
0 siblings, 1 reply; 2+ messages in thread
From: Andrei Emeltchenko @ 2014-11-21 9:48 UTC (permalink / raw)
To: linux-bluetooth
From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
"buf[0] & !1" is always 0, should be bitwise operation.
---
android/hidhost.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/android/hidhost.c b/android/hidhost.c
index 75e895b..b696563 100644
--- a/android/hidhost.c
+++ b/android/hidhost.c
@@ -465,7 +465,7 @@ static gboolean ctrl_io_watch_cb(GIOChannel *chan, gpointer data)
bt_hid_notify_handshake(dev, buf, bread);
break;
case HID_MSG_CONTROL:
- if ((buf[0] & !HID_MSG_TYPE_MASK) == HID_VIRTUAL_CABLE_UNPLUG)
+ if ((buf[0] & ~HID_MSG_TYPE_MASK) == HID_VIRTUAL_CABLE_UNPLUG)
bt_hid_notify_virtual_unplug(dev, buf, bread);
break;
default:
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] android/hidhost: Fix logical vs bitwise operation
2014-11-21 9:48 [PATCH] android/hidhost: Fix logical vs bitwise operation Andrei Emeltchenko
@ 2014-11-24 13:43 ` Szymon Janc
0 siblings, 0 replies; 2+ messages in thread
From: Szymon Janc @ 2014-11-24 13:43 UTC (permalink / raw)
To: Andrei Emeltchenko; +Cc: linux-bluetooth
Hi Andrei,
On Friday 21 of November 2014 11:48:50 Andrei Emeltchenko wrote:
> From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
>
> "buf[0] & !1" is always 0, should be bitwise operation.
> ---
> android/hidhost.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/android/hidhost.c b/android/hidhost.c
> index 75e895b..b696563 100644
> --- a/android/hidhost.c
> +++ b/android/hidhost.c
> @@ -465,7 +465,7 @@ static gboolean ctrl_io_watch_cb(GIOChannel *chan,
> gpointer data) bt_hid_notify_handshake(dev, buf, bread);
> break;
> case HID_MSG_CONTROL:
> - if ((buf[0] & !HID_MSG_TYPE_MASK) == HID_VIRTUAL_CABLE_UNPLUG)
> + if ((buf[0] & ~HID_MSG_TYPE_MASK) == HID_VIRTUAL_CABLE_UNPLUG)
> bt_hid_notify_virtual_unplug(dev, buf, bread);
> break;
> default:
Applied, thanks.
--
BR
Szymon Janc
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-11-24 13:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-21 9:48 [PATCH] android/hidhost: Fix logical vs bitwise operation Andrei Emeltchenko
2014-11-24 13:43 ` Szymon Janc
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).