linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Bluetooth: clean up error pointer checking
@ 2022-07-20 11:23 Dan Carpenter
  2022-07-20 12:02 ` bluez.test.bot
  2022-07-20 16:20 ` [PATCH] " patchwork-bot+bluetooth
  0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2022-07-20 11:23 UTC (permalink / raw)
  To: Marcel Holtmann, Luiz Augusto von Dentz
  Cc: Johan Hedberg, linux-bluetooth, kernel-janitors

The bt_skb_sendmsg() function can't return NULL so there is no need to
check for that.  Several of these checks were removed previously but
this one was missed.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 include/net/bluetooth/bluetooth.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/net/bluetooth/bluetooth.h b/include/net/bluetooth/bluetooth.h
index 6b48d9e2aab9..a8b52175af05 100644
--- a/include/net/bluetooth/bluetooth.h
+++ b/include/net/bluetooth/bluetooth.h
@@ -494,7 +494,7 @@ static inline struct sk_buff *bt_skb_sendmmsg(struct sock *sk,
 	struct sk_buff *skb, **frag;
 
 	skb = bt_skb_sendmsg(sk, msg, len, mtu, headroom, tailroom);
-	if (IS_ERR_OR_NULL(skb))
+	if (IS_ERR(skb))
 		return skb;
 
 	len -= skb->len;
-- 
2.35.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* RE: Bluetooth: clean up error pointer checking
  2022-07-20 11:23 [PATCH] Bluetooth: clean up error pointer checking Dan Carpenter
@ 2022-07-20 12:02 ` bluez.test.bot
  2022-07-20 16:20 ` [PATCH] " patchwork-bot+bluetooth
  1 sibling, 0 replies; 3+ messages in thread
From: bluez.test.bot @ 2022-07-20 12:02 UTC (permalink / raw)
  To: linux-bluetooth, dan.carpenter

[-- Attachment #1: Type: text/plain, Size: 1100 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=661424

---Test result---

Test Summary:
CheckPatch                    PASS      1.37 seconds
GitLint                       PASS      0.56 seconds
SubjectPrefix                 PASS      0.30 seconds
BuildKernel                   PASS      45.84 seconds
BuildKernel32                 PASS      40.97 seconds
Incremental Build with patchesPASS      69.34 seconds
TestRunner: Setup             PASS      676.66 seconds
TestRunner: l2cap-tester      PASS      19.85 seconds
TestRunner: bnep-tester       PASS      7.13 seconds
TestRunner: mgmt-tester       PASS      118.69 seconds
TestRunner: rfcomm-tester     PASS      11.35 seconds
TestRunner: sco-tester        PASS      11.69 seconds
TestRunner: smp-tester        PASS      11.14 seconds
TestRunner: userchan-tester   PASS      7.73 seconds



---
Regards,
Linux Bluetooth


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Bluetooth: clean up error pointer checking
  2022-07-20 11:23 [PATCH] Bluetooth: clean up error pointer checking Dan Carpenter
  2022-07-20 12:02 ` bluez.test.bot
@ 2022-07-20 16:20 ` patchwork-bot+bluetooth
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+bluetooth @ 2022-07-20 16:20 UTC (permalink / raw)
  To: Dan Carpenter
  Cc: marcel, luiz.dentz, johan.hedberg, linux-bluetooth,
	kernel-janitors

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Wed, 20 Jul 2022 14:23:49 +0300 you wrote:
> The bt_skb_sendmsg() function can't return NULL so there is no need to
> check for that.  Several of these checks were removed previously but
> this one was missed.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
>  include/net/bluetooth/bluetooth.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
  - Bluetooth: clean up error pointer checking
    https://git.kernel.org/bluetooth/bluetooth-next/c/3c7ec89ab45e

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-07-20 16:20 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-20 11:23 [PATCH] Bluetooth: clean up error pointer checking Dan Carpenter
2022-07-20 12:02 ` bluez.test.bot
2022-07-20 16:20 ` [PATCH] " patchwork-bot+bluetooth

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).