From: Szymon Janc <szymon.janc@tieto.com>
To: Grzegorz Kolodziejczyk <grzegorz.kolodziejczyk@tieto.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/5] android/tester: Add missing AVRCP cb_table entries
Date: Wed, 10 Dec 2014 13:43:57 +0100 [thread overview]
Message-ID: <1658533.bR5FcK4maG@leonov> (raw)
In-Reply-To: <1418034908-1742-1-git-send-email-grzegorz.kolodziejczyk@tieto.com>
Hi Grzegorz,
On Monday 08 of December 2014 11:35:04 Grzegorz Kolodziejczyk wrote:
> cb_table should be filled simultaneously with expected bt_callbacks
> enum. Without this, debug logs can cause errors.
> ---
> android/tester-main.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/android/tester-main.c b/android/tester-main.c
> index 33ef3ce..8f3bc3c 100644
> --- a/android/tester-main.c
> +++ b/android/tester-main.c
> @@ -68,6 +68,14 @@ static struct {
> DBG_CB(CB_A2DP_CONN_STATE),
> DBG_CB(CB_A2DP_AUDIO_STATE),
>
> + /* AVRCP */
> + DBG_CB(CB_AVRCP_PLAY_STATUS_REQ),
> + DBG_CB(CB_AVRCP_PLAY_STATUS_RSP),
> + DBG_CB(CB_AVRCP_REG_NOTIF_REQ),
> + DBG_CB(CB_AVRCP_REG_NOTIF_RSP),
> + DBG_CB(CB_AVRCP_GET_ATTR_REQ),
> + DBG_CB(CB_AVRCP_GET_ATTR_RSP),
> +
> /* Gatt client */
> DBG_CB(CB_GATTC_REGISTER_CLIENT),
> DBG_CB(CB_GATTC_SCAN_RESULT),
Patches 1-3 are now applied, thanks.
Please remember that commit message should start from capital letter. I've
fixed this for those patches.
--
BR
Szymon Janc
next prev parent reply other threads:[~2014-12-10 12:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-08 10:35 [PATCH 1/5] android/tester: Add missing AVRCP cb_table entries Grzegorz Kolodziejczyk
2014-12-08 10:35 ` [PATCH 2/5] android/tester: put gatt callback declaration in right place Grzegorz Kolodziejczyk
2014-12-08 10:35 ` [PATCH 3/5] android/tester: remove not needed include of hal_msg.h Grzegorz Kolodziejczyk
2014-12-08 10:35 ` [PATCH 4/5] android/tester: move bthost.h include to tester-main.h Grzegorz Kolodziejczyk
2014-12-10 12:45 ` Szymon Janc
2014-12-11 8:51 ` Grzegorz Kolodziejczyk
2014-12-08 10:35 ` [PATCH 5/5] android/tester: add initial support for map-client tester Grzegorz Kolodziejczyk
2014-12-10 12:56 ` Szymon Janc
2014-12-11 8:58 ` Grzegorz Kolodziejczyk
2014-12-10 12:43 ` Szymon Janc [this message]
2014-12-11 8:50 ` [PATCH 1/5] android/tester: Add missing AVRCP cb_table entries Grzegorz Kolodziejczyk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1658533.bR5FcK4maG@leonov \
--to=szymon.janc@tieto.com \
--cc=grzegorz.kolodziejczyk@tieto.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).