[PATCH] tools/btmgmt: add missing return statement

[PATCH] tools/btmgmt: add missing return statement

[Christian Eggers]

Leave function on error instead of printing (possibly) invalid flags.

Fixes: d70618e49461 ("tools/btmgmt: Add device flags commands")
Signed-off-by: Christian Eggers <ceggers@arri.de>
---
 tools/btmgmt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/btmgmt.c b/tools/btmgmt.c
index 42ef9acefaea..132ebb5f5b44 100644
--- a/tools/btmgmt.c
+++ b/tools/btmgmt.c
@@ -2183,7 +2183,7 @@ static void get_flags_rsp(uint8_t status, uint16_t len, const void *param,
 	if (status != 0) {
 		error("Get device flags failed with status 0x%02x (%s)",
 						status, mgmt_errstr(status));
-		bt_shell_noninteractive_quit(EXIT_FAILURE);
+		return bt_shell_noninteractive_quit(EXIT_FAILURE);
 	}
 
 	print("Supported Flags: 0x%08x", rp->supported_flags);
-- 
2.35.3

RE: tools/btmgmt: add missing return statement

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1978 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=671218

---Test result---

Test Summary:
CheckPatch                    FAIL      1.41 seconds
GitLint                       PASS      1.01 seconds
Prep - Setup ELL              PASS      27.43 seconds
Build - Prep                  PASS      0.80 seconds
Build - Configure             PASS      8.80 seconds
Build - Make                  PASS      881.01 seconds
Make Check                    PASS      12.10 seconds
Make Check w/Valgrind         PASS      289.54 seconds
Make Distcheck                PASS      241.93 seconds
Build w/ext ELL - Configure   PASS      8.90 seconds
Build w/ext ELL - Make        PASS      83.18 seconds
Incremental Build w/ patches  PASS      0.00 seconds
Scan Build                    PASS      519.10 seconds

Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script with rule in .checkpatch.conf
Output:
tools/btmgmt: add missing return statement
WARNING:UNKNOWN_COMMIT_ID: Unknown commit id 'd70618e49461', maybe rebased or not pulled?
#109: 
Fixes: d70618e49461 ("tools/btmgmt: Add device flags commands")

/github/workspace/src/12955219.patch total: 0 errors, 1 warnings, 8 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

/github/workspace/src/12955219.patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.




---
Regards,
Linux Bluetooth

Re: [PATCH] tools/btmgmt: add missing return statement

[patchwork-bot+bluetooth]

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Thu, 25 Aug 2022 22:38:48 +0200 you wrote:
> Leave function on error instead of printing (possibly) invalid flags.
> 
> Fixes: d70618e49461 ("tools/btmgmt: Add device flags commands")
> Signed-off-by: Christian Eggers <ceggers@arri.de>
> ---
>  tools/btmgmt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
  - tools/btmgmt: add missing return statement
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=150bbff449c7

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html