From: patchwork-bot+bluetooth@kernel.org
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: marcel@holtmann.org, johan.hedberg@gmail.com,
luiz.dentz@gmail.com,
syzbot+844c7bf1b1aa4119c5de@syzkaller.appspotmail.com,
linux-bluetooth@vger.kernel.org, syzkaller-bugs@googlegroups.com
Subject: Re: [PATCH] Bluetooth: avoid hci_dev_test_and_set_flag() in mgmt_init_hdev()
Date: Wed, 14 Sep 2022 20:10:15 +0000 [thread overview]
Message-ID: <166318621582.18930.5263572054834552054.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <f6de02d1-dcda-0383-739d-27484b4d5c63@I-love.SAKURA.ne.jp>
Hello:
This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:
On Mon, 12 Sep 2022 01:21:42 +0900 you wrote:
> syzbot is again reporting attempt to cancel uninitialized work
> at mgmt_index_removed() [1], for setting of HCI_MGMT flag from
> mgmt_init_hdev() from hci_mgmt_cmd() from hci_sock_sendmsg() can
> race with testing of HCI_MGMT flag from mgmt_index_removed() from
> hci_sock_bind() due to lack of serialization via hci_dev_lock().
>
> Since mgmt_init_hdev() is called with mgmt_chan_list_lock held, we can
> safely split hci_dev_test_and_set_flag() into hci_dev_test_flag() and
> hci_dev_set_flag(). Thus, in order to close this race, set HCI_MGMT flag
> after INIT_DELAYED_WORK() completed.
>
> [...]
Here is the summary with links:
- Bluetooth: avoid hci_dev_test_and_set_flag() in mgmt_init_hdev()
https://git.kernel.org/bluetooth/bluetooth-next/c/f74ca25d6d66
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2022-09-14 20:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-08 8:31 [syzbot] WARNING: ODEBUG bug in mgmt_index_removed syzbot
2022-09-10 11:18 ` Tetsuo Handa
2022-09-11 16:21 ` [PATCH] Bluetooth: avoid hci_dev_test_and_set_flag() in mgmt_init_hdev() Tetsuo Handa
2022-09-11 17:19 ` bluez.test.bot
2022-09-14 20:10 ` patchwork-bot+bluetooth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166318621582.18930.5263572054834552054.git-patchwork-notify@kernel.org \
--to=patchwork-bot+bluetooth@kernel.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=syzbot+844c7bf1b1aa4119c5de@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox