From: Szymon Janc <szymon.janc@tieto.com>
To: Marcin Kraglak <marcin.kraglak@tieto.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] android/gatt: Simplify find_device helper
Date: Mon, 31 Mar 2014 14:44:37 +0200 [thread overview]
Message-ID: <1669405.qm1PI0d5hl@uw000953> (raw)
In-Reply-To: <1396258005-30573-1-git-send-email-marcin.kraglak@tieto.com>
Hi Marcin,
On Monday 31 of March 2014 11:26:45 Marcin Kraglak wrote:
> We don't need to use dev pointer in second search attempt.
> ---
> android/gatt.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/android/gatt.c b/android/gatt.c
> index e361506..1bddbcf 100644
> --- a/android/gatt.c
> +++ b/android/gatt.c
> @@ -805,11 +805,7 @@ static struct gatt_device *find_device(bdaddr_t *addr)
> if (dev)
> return dev;
>
> - dev = queue_find(conn_wait_queue, match_dev_by_bdaddr, addr);
> - if (dev)
> - return dev;
> -
> - return NULL;
> + return queue_find(conn_wait_queue, match_dev_by_bdaddr, addr);
> }
>
> static struct gatt_device *find_device_by_conn_id(int32_t conn_id)
>
Patch applied, thanks.
--
Best regards,
Szymon Janc
prev parent reply other threads:[~2014-03-31 12:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-31 9:26 [PATCH] android/gatt: Simplify find_device helper Marcin Kraglak
2014-03-31 12:44 ` Szymon Janc [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1669405.qm1PI0d5hl@uw000953 \
--to=szymon.janc@tieto.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcin.kraglak@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox