From: Ping <pinglinux@gmail.com>
To: Jiri Kosina <jkosina@suse.cz>
Cc: "Przemysław Firszt" <przemo@firszt.eu>,
"Bastien Nocera" <hadess@hadess.net>,
linux-bluetooth@vger.kernel.org,
"Marcel Holtmann" <marcel@holtmann.org>,
"Peter Hutterer" <peter.hutterer@who-t.net>
Subject: Re: [PATCH] Fix pad button definition in hid-wacom.c
Date: Sun, 10 Jan 2010 10:35:21 -0800 [thread overview]
Message-ID: <167e8a331001101035t8db59b3p809d3aa5e475273f@mail.gmail.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1001091515520.7275@pobox.suse.cz>
2010/1/9 Jiri Kosina <jkosina@suse.cz>:
> On Sat, 9 Jan 2010, Przemys=C5=82aw Firszt wrote:
>
>> There is one more change required to get the pad buttons on wacom
>> bluetooth tablet fully working - see attached patch.
>
> Applied, thanks.
>
> --
> Jiri Kosina
> SUSE Labs, Novell Inc.
>
The patch below is needed for Wacom X.Org driver to receive the proper
PAD button events. It is based on Przemo's applied patch attached to
this email sting.
Signed-off-by: Ping Cheng <pingc@wacom.com>
--- hid-wacom.c_old 2010-01-10 10:25:48.236272275 -0800
+++ hid-wacom.c 2010-01-10 10:25:45.216272921 -0800
@@ -197,6 +197,9 @@
/* Pad */
input->evbit[0] |=3D BIT(EV_MSC);
input->mscbit[0] |=3D BIT(MSC_SERIAL);
+ set_bit(BTN_0, input->keybit);
+ set_bit(BTN_1, input->keybit);
+ set_bit(BTN_TOOL_FINGER, input->keybit);
/* Distance, rubber and mouse */
input->absbit[0] |=3D BIT(ABS_DISTANCE);
next prev parent reply other threads:[~2010-01-10 18:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-03 18:46 [PATCH] Fix pad button definition in hid-wacom.c Przemysław Firszt
2010-01-04 11:24 ` Jiri Kosina
2010-01-04 15:39 ` Bastien Nocera
2010-01-09 14:11 ` Przemysław Firszt
2010-01-09 14:16 ` Jiri Kosina
2010-01-10 18:35 ` Ping [this message]
2010-01-12 13:36 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167e8a331001101035t8db59b3p809d3aa5e475273f@mail.gmail.com \
--to=pinglinux@gmail.com \
--cc=hadess@hadess.net \
--cc=jkosina@suse.cz \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=peter.hutterer@who-t.net \
--cc=przemo@firszt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).