From: patchwork-bot+bluetooth@kernel.org
To: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
Cc: marcel@holtmann.org, johan.hedberg@gmail.com,
luiz.dentz@gmail.com, linux-kernel@vger.kernel.org,
linux-bluetooth@vger.kernel.org, amitkumar.karwar@nxp.com,
rohit.fule@nxp.com, sherry.sun@nxp.com
Subject: Re: [PATCH v1] Bluetooth: btnxpuart: No need to check the received bootloader signature
Date: Thu, 06 Apr 2023 21:00:20 +0000 [thread overview]
Message-ID: <168081482061.2619.11741204657524521970.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20230403122430.1024235-4-neeraj.sanjaykale@nxp.com>
Hello:
This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:
On Mon, 3 Apr 2023 17:54:30 +0530 you wrote:
> We can never assume the uart will deliver a complete packet to the BT
> layer at once, the expected packet may be divided into several parts by
> uart as uart doesn't know the received packet size, the received data
> count may mismatch with the expected packet size, so here
> is_valid_bootloader_signature() check may always return false.
>
> Even we remove the count check in is_valid_bootloader_signature(), then
> the first part of the data which includes the packet type can pass the
> is_valid_bootloader_signature() check, but the remaining parts don't
> have the packet type data still cannot pass the check, here return
> directly will cause the data loss.
>
> [...]
Here is the summary with links:
- [v1] Bluetooth: btnxpuart: No need to check the received bootloader signature
https://git.kernel.org/bluetooth/bluetooth-next/c/b1ff41fd0ee6
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
next prev parent reply other threads:[~2023-04-06 21:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-03 12:24 [PATCH v1] Bluetooth: btnxpuart: Add support to download helper FW file for w8997 Neeraj Sanjay Kale
2023-04-03 12:24 ` [PATCH v1] Bluetooth: btnxpuart: Deasset UART break before closing serdev device Neeraj Sanjay Kale
2023-04-03 13:13 ` [v1] " bluez.test.bot
2023-04-06 21:00 ` [PATCH v1] " patchwork-bot+bluetooth
2023-04-03 12:24 ` [PATCH v1] Bluetooth: btnxpuart: Disable Power Save feature on startup Neeraj Sanjay Kale
2023-04-03 13:13 ` [v1] " bluez.test.bot
2023-04-06 21:00 ` [PATCH v1] " patchwork-bot+bluetooth
2023-04-03 12:24 ` [PATCH v1] Bluetooth: btnxpuart: No need to check the received bootloader signature Neeraj Sanjay Kale
2023-04-03 13:13 ` [v1] " bluez.test.bot
2023-04-06 21:00 ` patchwork-bot+bluetooth [this message]
2023-04-03 13:13 ` [v1] Bluetooth: btnxpuart: Add support to download helper FW file for w8997 bluez.test.bot
2023-04-06 21:00 ` [PATCH v1] " patchwork-bot+bluetooth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168081482061.2619.11741204657524521970.git-patchwork-notify@kernel.org \
--to=patchwork-bot+bluetooth@kernel.org \
--cc=amitkumar.karwar@nxp.com \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=neeraj.sanjaykale@nxp.com \
--cc=rohit.fule@nxp.com \
--cc=sherry.sun@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).