[PATCH BlueZ v4 0/2] configure.ac: Install D-Bus policy in /usr/share, not /etc

[PATCH BlueZ v4 0/2] configure.ac: Install D-Bus policy in /usr/share, not /etc

[Gioele Barabucci]

[Sending again, this time with the right commit titles. Sorry for the noise.]

This patch changes configure.am to install the bluez D-Bus policy in
`/usr/share/dbus-1/system.d` instead of `/etc/dbus-1/system.d`.

From https://bugs.debian.org/1006631:

> dbus supports policy files in both /usr/share/dbus-1/system.d and
> /etc/dbus-1/systemd. [The] recently released dbus 1.14.0, officially
> deprecates installing packages' default policies into /etc/dbus-1/systemd,
> instead reserving it for the sysadmin. This is the same idea as the
> difference between /usr/lib/udev/rules.d and /etc/udev/rules.d.

D-Bus supports reading policies from /usr since version 1.10,
released in 2015:
https://sources.debian.org/src/dbus/1.10.32-0%2Bdeb9u1/NEWS/#L483-L499

Regards,

v1 -> v2:
- bump D-Bus min version
- derive DBUS_CONFDIR from datadir

v2 -> v3:
- split in two commits

v3 -> v4:
- reorder commits and fix titles

Gioele Barabucci (2):
  configure.ac: Bump minimum D-Bus version to 1.10
  configure.ac: Install D-Bus policy in /usr/share, not /etc

 configure.ac | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

-- 
2.39.2

[PATCH BlueZ v4 1/2] configure.ac: Bump minimum D-Bus version to 1.10

[Gioele Barabucci]

D-Bus 1.10, released in 2015, is the first version that supports reading
policy files from `/usr/share/dbus-1` in addition to `/etc/dbus-1`.

The previous minimum version, 1.6, was released in 2012.
---
 configure.ac | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/configure.ac b/configure.ac
index bc7edfcd3..298b8cd59 100644
--- a/configure.ac
+++ b/configure.ac
@@ -85,8 +85,8 @@ if (test "${enable_threads}" = "yes"); then
 	GLIB_LIBS="$GLIB_LIBS $GTHREAD_LIBS"
 fi
 
-PKG_CHECK_MODULES(DBUS, dbus-1 >= 1.6, dummy=yes,
-				AC_MSG_ERROR(D-Bus >= 1.6 is required))
+PKG_CHECK_MODULES(DBUS, dbus-1 >= 1.10, dummy=yes,
+				AC_MSG_ERROR(D-Bus >= 1.10 is required))
 AC_SUBST(DBUS_CFLAGS)
 AC_SUBST(DBUS_LIBS)
 
-- 
2.39.2

RE: configure.ac: Install D-Bus policy in /usr/share, not /etc

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 948 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=774393

---Test result---

Test Summary:
CheckPatch                    PASS      0.95 seconds
GitLint                       PASS      0.69 seconds
BuildEll                      PASS      27.58 seconds
BluezMake                     PASS      889.39 seconds
MakeCheck                     PASS      12.96 seconds
MakeDistcheck                 PASS      159.07 seconds
CheckValgrind                 PASS      258.58 seconds
CheckSmatch                   PASS      347.14 seconds
bluezmakeextell               PASS      105.28 seconds
IncrementalBuild              PASS      1470.25 seconds
ScanBuild                     PASS      1075.30 seconds



---
Regards,
Linux Bluetooth

[PATCH BlueZ v4 2/2] configure.ac: Install D-Bus policy in /usr/share, not /etc

[Gioele Barabucci]

From https://bugs.debian.org/1006631:

> dbus supports policy files in both `/usr/share/dbus-1/system.d` and
> `/etc/dbus-1/systemd`. [The] recently released dbus 1.14.0, officially
> deprecates installing packages' default policies into
> `/etc/dbus-1/systemd`, instead reserving it for the sysadmin.
> This is the same idea as the difference between `/usr/lib/udev/rules.d`
> and `/etc/udev/rules.d`.
---
 configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index 298b8cd59..ad864dea7 100644
--- a/configure.ac
+++ b/configure.ac
@@ -95,7 +95,7 @@ AC_ARG_WITH([dbusconfdir], AS_HELP_STRING([--with-dbusconfdir=DIR],
 					[path_dbusconfdir=${withval}])
 if (test -z "${path_dbusconfdir}"); then
 	AC_MSG_CHECKING([D-Bus configuration directory])
-	path_dbusconfdir="`$PKG_CONFIG --variable=sysconfdir dbus-1`"
+	path_dbusconfdir="`$PKG_CONFIG --variable=datadir dbus-1`"
 	if (test -z "${path_dbusconfdir}"); then
 		AC_MSG_ERROR([D-Bus configuration directory is required])
 	fi
-- 
2.39.2

Re: [PATCH BlueZ v4 0/2] configure.ac: Install D-Bus policy in /usr/share, not /etc

[patchwork-bot+bluetooth]

Hello:

This series was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Wed,  9 Aug 2023 08:51:41 +0200 you wrote:
> [Sending again, this time with the right commit titles. Sorry for the noise.]
> 
> This patch changes configure.am to install the bluez D-Bus policy in
> `/usr/share/dbus-1/system.d` instead of `/etc/dbus-1/system.d`.
> 
> From https://bugs.debian.org/1006631:
> 
> [...]

Here is the summary with links:
  - [BlueZ,v4,1/2] configure.ac: Bump minimum D-Bus version to 1.10
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=8b6432a8728f
  - [BlueZ,v4,2/2] configure.ac: Install D-Bus policy in /usr/share, not /etc
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=fc6f5856d177

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html