[PATCH BlueZ v2] mesh: Fix check for active scan when using generic IO

[PATCH BlueZ v2] mesh: Fix check for active scan when using generic IO

[Inga Stotland]

This modifies the check for an active scan in generic IO:
the bug has been introduced during earlier code refactoring.

Fixes: https://github.com/bluez/bluez/issues/625
---
 mesh/mesh-io-generic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mesh/mesh-io-generic.c b/mesh/mesh-io-generic.c
index 00932ade7..13a863b48 100644
--- a/mesh/mesh-io-generic.c
+++ b/mesh/mesh-io-generic.c
@@ -781,7 +781,7 @@ static bool recv_register(struct mesh_io *io, const uint8_t *filter,
 	bool already_scanning;
 	bool active = false;
 
-	already_scanning = !l_queue_isempty(io->rx_regs);
+	already_scanning = l_queue_length(io->rx_regs) > 1;
 
 	/* Look for any AD types requiring Active Scanning */
 	if (l_queue_find(io->rx_regs, find_active, NULL))
-- 
2.41.0

RE: [BlueZ,v2] mesh: Fix check for active scan when using generic IO

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 949 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=793761

---Test result---

Test Summary:
CheckPatch                    PASS      0.57 seconds
GitLint                       PASS      1.14 seconds
BuildEll                      PASS      36.74 seconds
BluezMake                     PASS      1225.66 seconds
MakeCheck                     PASS      14.24 seconds
MakeDistcheck                 PASS      230.61 seconds
CheckValgrind                 PASS      350.93 seconds
CheckSmatch                   PASS      483.93 seconds
bluezmakeextell               PASS      155.13 seconds
IncrementalBuild              PASS      1108.57 seconds
ScanBuild                     PASS      1486.37 seconds



---
Regards,
Linux Bluetooth

Re: [PATCH BlueZ v2] mesh: Fix check for active scan when using generic IO

[patchwork-bot+bluetooth]

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Brian Gix <brian.gix@gmail.com>:

On Mon, 16 Oct 2023 17:21:23 -0700 you wrote:
> This modifies the check for an active scan in generic IO:
> the bug has been introduced during earlier code refactoring.
> 
> Fixes: https://github.com/bluez/bluez/issues/625
> ---
>  mesh/mesh-io-generic.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
  - [BlueZ,v2] mesh: Fix check for active scan when using generic IO
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=0c757e8eeef6

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html