Re: [PATCH] Bluetooth: Add Synaptcis 4384 Chip Support

[Paul Menzel <pmenzel@molgen.mpg.de>]

Dear Kaihsin,


Thank you for your patch.

Am 08.04.26 um 10:32 schrieb kaihsin:

Please add an elaborate commit message.

> Signed-off-by: kaihsin <kaihsin.chung@synaptics.com>

Please configure to use the full name:

     git config --global user.name "Kaihsin Chung"
     git commit --amend --author="Kaihsin Chung 
<kaihsin.chung@synaptics.com>" -s

Then please re-roll as v2 (`git format-patch -v2 …`).

> ---
>   drivers/bluetooth/btbcm.c   | 2 ++
>   drivers/bluetooth/hci_bcm.c | 3 ++-
>   2 files changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/bluetooth/btbcm.c b/drivers/bluetooth/btbcm.c
> index f9a7c790d7e2..21ef875d6aa7 100644
> --- a/drivers/bluetooth/btbcm.c
> +++ b/drivers/bluetooth/btbcm.c
> @@ -515,6 +515,8 @@ static const struct bcm_subver_table bcm_uart_subver_table[] = {
>   	{ 0x4106, "BCM4335A0"	},	/* 002.001.006 */
>   	{ 0x410c, "BCM43430B0"	},	/* 002.001.012 */
>   	{ 0x2119, "BCM4373A0"	},	/* 001.001.025 */
> +	{ 0x2128, "BCM4384A0_AP6684P" },/* 001.001.040 */
> +	{ 0x4119, "BCM4384B0_AP6684PL"},/* 002.001.025 */
>   	{ }
>   };
>   
> diff --git a/drivers/bluetooth/hci_bcm.c b/drivers/bluetooth/hci_bcm.c
> index 874d23089b39..972685e83b8a 100644
> --- a/drivers/bluetooth/hci_bcm.c
> +++ b/drivers/bluetooth/hci_bcm.c
> @@ -1609,7 +1609,8 @@ static const struct of_device_id bcm_bluetooth_of_match[] = {
>   	{ .compatible = "brcm,bcm4335a0" },
>   	{ .compatible = "cypress,cyw4373a0-bt", .data = &cyw4373a0_device_data },
>   	{ .compatible = "infineon,cyw55572-bt", .data = &cyw55572_device_data },
> -	{ },
> +	{ .compatible = "brcm,bcm4384-bt" },
> +	{ },

Any idea, why the empty element is shown as changed?

>   };
>   MODULE_DEVICE_TABLE(of, bcm_bluetooth_of_match);
>   #endif


Kind regards,

Paul