Linux bluetooth development
 help / color / mirror / Atom feed
From: Szymon Janc <szymon.janc@tieto.com>
To: Jakub Tyszkowski <jakub.tyszkowski@tieto.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] android/build: Fix build for kitkat
Date: Fri, 14 Nov 2014 16:36:59 +0100	[thread overview]
Message-ID: <17063377.1M6GrS82sa@uw000953> (raw)
In-Reply-To: <1415977443-16255-1-git-send-email-jakub.tyszkowski@tieto.com>

Hi Jakub,

On Friday 14 of November 2014 16:04:03 Jakub Tyszkowski wrote:
> Fix missing kitkat build failure:
> external/bluetooth/bluez/android/client/if-hf.c: At top level:
> external/bluetooth/bluez/android/client/if-hf.c:108:1: error: unknown
> type name 'bthf_wbs_config_t'
> external/bluetooth/bluez/android/client/if-hf.c:108:1: error: unknown
> type name 'bthf_wbs_config_t'
> external/bluetooth/bluez/android/client/if-hf.c: In function
> 'str2bthf_wbs_config_t':
> external/bluetooth/bluez/android/client/if-hf.c:108:1: error:
> 'bthf_wbs_config_t' undeclared (first use in this function)
> external/bluetooth/bluez/android/client/if-hf.c:108:1: note: each
> undeclared identifier is reported only once for each function it appears
> in
> external/bluetooth/bluez/android/client/if-hf.c: At top level:
> external/bluetooth/bluez/android/client/if-hf.c:109:2: error:
> 'BTHF_WBS_NONE' undeclared here (not in a function)
> external/bluetooth/bluez/android/client/if-hf.c:110:2: error:
> 'BTHF_WBS_NO' undeclared here (not in a function)
> external/bluetooth/bluez/android/client/if-hf.c:111:2: error:
> 'BTHF_WBS_YES' undeclared here (not in a function)
> make: ***
> [out/target/product/hammerhead/obj/EXECUTABLES/haltest_intermediates/bluez/android/client/if-hf.o]
> Error 1
> ---
>  android/client/if-hf.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/android/client/if-hf.c b/android/client/if-hf.c
> index d24612a..6b798f8 100644
> --- a/android/client/if-hf.c
> +++ b/android/client/if-hf.c
> @@ -105,11 +105,13 @@ SINTMAP(bthf_call_addrtype_t, -1, "(unknown)")
>  	DELEMENT(BTHF_CALL_ADDRTYPE_INTERNATIONAL),
>  ENDMAP
>  
> +#if ANDROID_VERSION >= PLATFORM_VER(5, 0, 0)
>  SINTMAP(bthf_wbs_config_t, -1, "(unknown)")
>  	DELEMENT(BTHF_WBS_NONE),
>  	DELEMENT(BTHF_WBS_NO),
>  	DELEMENT(BTHF_WBS_YES),
>  ENDMAP
> +#endif
>  
>  /* Callbacks */
>  

Applied, thanks. 

-- 
Best regards, 
Szymon Janc

      reply	other threads:[~2014-11-14 15:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-14 15:04 [PATCH] android/build: Fix build for kitkat Jakub Tyszkowski
2014-11-14 15:36 ` Szymon Janc [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17063377.1M6GrS82sa@uw000953 \
    --to=szymon.janc@tieto.com \
    --cc=jakub.tyszkowski@tieto.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox