[PATCH BlueZ] advertising: Do not set timer if DiscoverableTimeout=0

[PATCH BlueZ] advertising: Do not set timer if DiscoverableTimeout=0

[Arkadiusz Bokowy]

According to org.bluez.LEAdvertisement.rst documentation, the value of
zero should disable timeout and keep device in the discoverable mode
forever.
---
 src/advertising.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/advertising.c b/src/advertising.c
index 2c9a5a443..c036065c4 100644
--- a/src/advertising.c
+++ b/src/advertising.c
@@ -1065,7 +1065,9 @@ static bool parse_discoverable_timeout(DBusMessageIter *iter,
 	if (client->disc_to_id)
 		timeout_remove(client->disc_to_id);
 
-	client->disc_to_id = timeout_add_seconds(client->discoverable_to,
+	if (client->discoverable_to > 0)
+		client->disc_to_id = timeout_add_seconds(
+						client->discoverable_to,
 						client_discoverable_timeout,
 						client, NULL);
 
-- 
2.39.2

RE: [BlueZ] advertising: Do not set timer if DiscoverableTimeout=0

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 946 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=825610

---Test result---

Test Summary:
CheckPatch                    PASS      0.43 seconds
GitLint                       PASS      0.31 seconds
BuildEll                      PASS      24.19 seconds
BluezMake                     PASS      737.22 seconds
MakeCheck                     PASS      11.86 seconds
MakeDistcheck                 PASS      165.19 seconds
CheckValgrind                 PASS      227.24 seconds
CheckSmatch                   PASS      328.63 seconds
bluezmakeextell               PASS      107.30 seconds
IncrementalBuild              PASS      698.83 seconds
ScanBuild                     PASS      974.22 seconds



---
Regards,
Linux Bluetooth

Re: [PATCH BlueZ] advertising: Do not set timer if DiscoverableTimeout=0

[patchwork-bot+bluetooth]

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Tue, 13 Feb 2024 14:12:05 +0100 you wrote:
> According to org.bluez.LEAdvertisement.rst documentation, the value of
> zero should disable timeout and keep device in the discoverable mode
> forever.
> ---
>  src/advertising.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Here is the summary with links:
  - [BlueZ] advertising: Do not set timer if DiscoverableTimeout=0
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=c58a4d9f7880

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html