linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Szymon Janc <szymon.janc@tieto.com>
To: Sebastian Chlad <sebastian.chlad@tieto.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] android/pts: Update PTS files for L2CAP
Date: Tue, 19 Aug 2014 19:32:53 +0200	[thread overview]
Message-ID: <1718033.X82NjRYrDX@leonov> (raw)
In-Reply-To: <1408437154-7274-2-git-send-email-sebastian.chlad@tieto.com>

Hi Sebastian,

On Tuesday 19 of August 2014 10:32:34 Sebastian Chlad wrote:
> PICS and PIXITs checked against PTS 5.2. Regression round on PTS
> 5.2 against Android 4.4.4. Interim results.
> ---
>  android/pics-l2cap.txt  | 11 +++++++----
>  android/pixit-l2cap.txt |  2 +-
>  android/pts-l2cap.txt   | 46 ++++++++++++++++++++++++----------------------
> 3 files changed, 32 insertions(+), 27 deletions(-)
> 
> diff --git a/android/pics-l2cap.txt b/android/pics-l2cap.txt
> index 53e6b9f..8e726e4 100644
> --- a/android/pics-l2cap.txt
> +++ b/android/pics-l2cap.txt
> @@ -1,6 +1,6 @@
>  L2CAP PICS for the PTS tool.
> 
> -PTS version: 5.1
> +PTS version: 5.2
> 
>  * - different than PTS defaults
>  # - not yet implemented/supported
> @@ -70,7 +70,8 @@ TSPC_L2CAP_2_31	False		AMP Manager Support (C.12)
>  TSPC_L2CAP_2_32	False		ERTM over AMP (C.12)
>  TSPC_L2CAP_2_33	False		Streaming Mode Source over AMP Support (C.15)
>  TSPC_L2CAP_2_34	False		Streaming Mode Sink over AMP Support (C.15)
> -TSPC_L2CAP_2_35	True (*)	Unicast Connectionless Data, Reception (C.1, 
C.16)
> +TSPC_L2CAP_2_35	True (*)	Unicast Connectionless Data, Reception
> +				(C.1, C.16)
>  TSPC_L2CAP_2_36	True (*)	Ability to transmit an unencrypted packet over
>  					a Unicast connectionless L2CAP
>  					channel (C.16)
> @@ -105,7 +106,8 @@ C.10: Optional IF TSPC_L2CAP_2_12 is claimed, ELSE
> Excluded. C.11: Optional IF TSPC_L2CAP_2_12 is claimed, ELSE Excluded.
>  C.12: Mandatory IF SUM_ICS 31/9 (3.0 + HS) is claimed, ELSE Optional.
>  C.13: Mandatory IF SUM_ICS 31/9 (3.0 + HS) is claimed, ELSE Optional.
> -C.14: Optional IF SUM_ICS 31/8 OR 31/9 OR 31/10 OR 31/11 is claimed, ELSE
> Excluded. +C.14: Optional IF SUM_ICS 31/8 OR 31/9 OR 31/10 OR 31/11 is
> claimed, +	ELSE Excluded.
>  C.15: Optional IF TSPC_L2CAP_2_29 is claimed, ELSE Excluded.
>  C.16: Optional IF (SUM_ICS 31/8 OR SUM_ICS 31/9 OR 31/10 OR 31/11) is
> claimed, ELSE Excluded.
> @@ -154,6 +156,7 @@ C.4: Mandatory IF BR/EDR OR BR/EDR/LE is claimed, ELSE
> Excluded. C.5: Optional IF BR/EDR OR BR/EDR/LE is claimed, ELSE Excluded.
>  C.6: Mandatory IF LE OR BR/EDR/LE is claimed, ELSE Excluded.
>  C.7: Optional if TSPC_L2CAP_2_44 OR TSPC_L2CAP_2_38 is supported, ELSE
> Excluded. -C.8: Mandatory if TSPC_L2CAP_2_44 OR TSPC_L2CAP_2_38 is
> supported, ELSE Excluded. +C.8: Mandatory if TSPC_L2CAP_2_44 OR
> TSPC_L2CAP_2_38 is supported, +	ELSE Excluded.
>  C.9: Optional if TSPC_L2CAP_2_44 OR TSPC_L2CAP_2_38 is supported, ELSE
> Excluded.
> ---------------------------------------------------------------------------
> ---- diff --git a/android/pixit-l2cap.txt b/android/pixit-l2cap.txt
> index 914a995..401e584 100644
> --- a/android/pixit-l2cap.txt
> +++ b/android/pixit-l2cap.txt
> @@ -1,6 +1,6 @@
>  L2CAP PIXIT for the PTS tool.
> 
> -PTS version: 5.1
> +PTS version: 5.2
> 
>  * - different than PTS defaults
>  & - should be set to IUT Bluetooth address
> diff --git a/android/pts-l2cap.txt b/android/pts-l2cap.txt
> index 29e6d7c..0746ea7 100644
> --- a/android/pts-l2cap.txt
> +++ b/android/pts-l2cap.txt
> @@ -1,9 +1,9 @@
>  PTS test results for L2CAP
> 
> -PTS version: 5.1
> -Tested: 27-June-2014
> -Android version: 4.4.2
> -Kernel version: 3.17
> +PTS version: 5.2
> +Tested: 14-August-2014
> +Android version: 4.4.4
> +Kernel version: 3.18
> 
>  Results:
>  PASS   test passed
> @@ -58,8 +58,8 @@ TC_CMC_BV_08_C		PASS	l2test -r -X streaming -P 4113
>  TC_CMC_BV_09_C		PASS	l2test -r -X basic -P 4113
>  TC_CMC_BV_10_C		PASS	l2test -n -P 4113 <bdaddr>
>  TC_CMC_BV_11_C		PASS	l2test -n -P 4113 <bdaddr>
> -TC_CMC_BV_12_C		PASS	l2test -s -X ertm -P 4113 -U <bdaddr>
> -TC_CMC_BV_13_C		PASS	l2test -s -X ertm -P 4113 -U <bdaddr>
> +TC_CMC_BV_12_C		PASS	l2test -z -X ertm <bdaddr>
> +TC_CMC_BV_13_C		PASS	l2test -z -X ertm <bdaddr>
>  TC_CMC_BV_14_C		PASS	l2test -r -X streaming -P 4113
>  TC_CMC_BV_15_C		PASS	l2test -r -X streaming -P 4113
>  TC_CMC_BI_01_C		PASS	l2test -r -X ertm -P 4113
> @@ -71,10 +71,9 @@ TC_CMC_BI_06_C		PASS	l2test -r -P 4113
>  TC_FOC_BV_01_C		PASS	l2test -r -X ertm -P 4113 -F 0
>  TC_FOC_BV_02_C		PASS	l2test -r -X ertm -P 4113 -F 0
>  TC_FOC_BV_03_C		PASS	l2test -r -X ertm -P 4113 -F 0
> -TC_FOC_BV_04_C		PASS	l2test -r -X ertm -P 4113 -F 0
> -TC_OFS_BV_01_C		PASS	l2test -x -X ertm -P 4113 -F 0 N 1
> +TC_OFS_BV_01_C		PASS	l2test -x -X ertm -P 4113 -F 0 -N 1
>  TC_OFS_BV_02_C		PASS	l2test -r -X ertm -P 4113 -F 0
> -TC_OFS_BV_03_C		PASS	l2test -r -X streaming -P 4113 -F 0
> +TC_OFS_BV_03_C		PASS	l2test -x -X streaming -P 4113 -F 0 -N 1
>  TC_OFS_BV_04_C		PASS	l2test -r -X streaming -P 4113 -F 0
>  TC_OFS_BV_05_C		PASS	l2test -x -X ertm -P 4113 -N 1
>  TC_OFS_BV_06_C		PASS	l2test -r -X ertm -P 4113
> @@ -85,31 +84,31 @@ TC_ERM_BV_02_C		PASS	l2test -r -X ertm -P 4113
>  TC_ERM_BV_03_C		PASS	l2test -r -X ertm -P 4113
>  TC_ERM_BV_05_C		PASS	l2test -x -X ertm -P 4113 -N 2 -Y 2
>  TC_ERM_BV_06_C		PASS	l2test -x -X ertm -P 4113 -N 2 -Y 2
> -TC_ERM_BV_07_C		PASS	l2test -X ertm -P 4113
> +TC_ERM_BV_07_C		PASS	l2test -r -H 1000 -K 10000 -X ertm -P 4113
>  TC_ERM_BV_08_C		PASS	l2test -x -X ertm -P 4113 -N 1
>  TC_ERM_BV_09_C		PASS	l2test -X ertm -P 4113
>  TC_ERM_BV_10_C		PASS	l2test -x -X ertm -P 4113 -N 1
>  TC_ERM_BV_11_C		PASS	l2test -x -X ertm -P 4113 -N 1 -Q 1
>  TC_ERM_BV_12_C		PASS	l2test -x -X ertm -P 4113 -R -N 1 -Q 1
> -TC_ERM_BV_13_C		PASS
> -TC_ERM_BV_14_C		PASS
> -TC_ERM_BV_15_C		PASS	l2test -X ertm -P 4113 -N 4 -Y 4
> +TC_ERM_BV_13_C		PASS	l2test -x -X ertm -P 4113 -N 2
> +TC_ERM_BV_14_C		PASS	l2test -x -X ertm -P 4113 -N 4
> +TC_ERM_BV_15_C		PASS	l2test -X ertm -P 4113 -N 4
>  TC_ERM_BV_16_C		N/A
>  TC_ERM_BV_17_C		PASS	l2test -X ertm -P 4113
> -TC_ERM_BV_18_C		PASS
> -TC_ERM_BV_19_C		PASS	l2test -x -X ertm -P 4113 -N 1
> +TC_ERM_BV_18_C		PASS	l2test -x -X ertm -P 4113 -N 1
> +TC_ERM_NV_19_C		PASS	l2test -x -X ertm -P 4113 -N 1
>  TC_ERM_BV_20_C		PASS	l2test -x -X ertm -P 4113 -N 1
> -TC_ERM_BV_21_C		PASS	l2test -w -X ertm -P 4113 -N 3
> -TC_ERM_BV_22_C		PASS
> -TC_ERM_BV_23_C		PASS
> +TC_ERM_BV_21_C		PASS	l2test -x -X ertm -P 4113 -D 2000 -N 2
> +TC_ERM_BV_22_C		PASS	l2test -r -H 1000 -K 5000 -X ertm -P 4113
> +TC_ERM_BV_23_C		PASS	l2test -x -X ertm -P 4113 -N 2
>  TC_ERM_BI_01_C		N/A
>  TC_ERM_BI_02_C		PASS	l2test -X ertm -P 4113
> -TC_ERM_BI_03_C		PASS
> -TC_ERM_BI_04_C		PASS
> -TC_ERM_BI_05_C		PASS
> +TC_ERM_BI_03_C		PASS	l2test -x -X ertm -P 4113 -N 2
> +TC_ERM_BI_04_C		PASS	l2test -x -X ertm -P 4113 -N 2
> +TC_ERM_BI_05_C		PASS	l2test -x -X ertm -P 4113 -N 2
>  TC_STM_BV_01_C		PASS	l2test -x -X streaming -P 4113 -N 3 -Y 3
>  TC_STM_BV_02_C		PASS	l2test -r -X streaming -P 4113
> -TC_STM_BV_03_C		PASS
> +TC_STM_BV_03_C		PASS	l2test -x -X streaming -P 4113 -N 2
>  TC_STM_BV_11_C		N/A
>  TC_STM_BV_12_C		N/A
>  TC_STM_BV_13_C		N/A
> @@ -142,6 +141,9 @@ TC_ECF_BV_05_C		N/A
>  TC_ECF_BV_06_C		N/A
>  TC_ECF_BV_07_C		N/A
>  TC_ECF_BV_08_C		N/A
> +				NOTE: for LE tests daemon should be stopped
> +				then:
> +				setprop ctl.start hciattach
>  TC_LE_CPU_BV_01_C	PASS	l2test -r -V le_public -J 4
>  TC_LE_CPU_BV_02_C	PASS	l2test -n -V le_public -J 4 <braddr>
>  TC_LE_CPU_BI_01_C	PASS	l2test -n -V le_public -J 4 <braddr>

Applied. Thanks.

-- 
BR
Szymon Janc

      reply	other threads:[~2014-08-19 17:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-06 14:11 [PATCH] android/pts: Update PTS files for L2CAP Sebastian Chlad
2014-08-11 11:17 ` Lukasz Rymanowski
2014-08-11 12:41   ` Sebastian Chlad
2014-08-12 13:38 ` [PATCH] Interim test results " Sebastian Chlad
2014-08-12 13:38   ` [PATCH] android/pts: Update PTS files " Sebastian Chlad
2014-08-19  8:32 ` [PATCH] L2CAP tests on PTS 5.2 Sebastian Chlad
2014-08-19  8:32   ` [PATCH] android/pts: Update PTS files for L2CAP Sebastian Chlad
2014-08-19 17:32     ` Szymon Janc [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1718033.X82NjRYrDX@leonov \
    --to=szymon.janc@tieto.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=sebastian.chlad@tieto.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).