[PATCH BlueZ v1] hog-lib: Fix passing wrong parameters to bt_uhid_get_report_reply

[PATCH BlueZ v1] hog-lib: Fix passing wrong parameters to bt_uhid_get_report_reply

[Luiz Augusto von Dentz]

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

The parameters of bt_uhid_get_report_reply are number followed by
status, not status followed by number, so the order needs to be
swapped.

Fixes: https://github.com/bluez/bluez/issues/880
---
 profiles/input/hog-lib.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/profiles/input/hog-lib.c b/profiles/input/hog-lib.c
index 67a0e832dc98..1b4aca07486b 100644
--- a/profiles/input/hog-lib.c
+++ b/profiles/input/hog-lib.c
@@ -904,7 +904,7 @@ static void report_reply(struct bt_hog *hog, uint8_t status, uint8_t id,
 
 	hog->getrep_att = 0;
 
-	err = bt_uhid_get_report_reply(hog->uhid, hog->getrep_id, status, id,
+	err = bt_uhid_get_report_reply(hog->uhid, hog->getrep_id, id, status,
 					data, len);
 	if (err < 0)
 		error("bt_uhid_get_report_reply: %s", strerror(-err));
-- 
2.45.2

RE: [BlueZ,v1] hog-lib: Fix passing wrong parameters to bt_uhid_get_report_reply

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 948 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=865048

---Test result---

Test Summary:
CheckPatch                    PASS      0.42 seconds
GitLint                       PASS      0.29 seconds
BuildEll                      PASS      26.02 seconds
BluezMake                     PASS      1663.87 seconds
MakeCheck                     PASS      13.46 seconds
MakeDistcheck                 PASS      178.03 seconds
CheckValgrind                 PASS      251.27 seconds
CheckSmatch                   PASS      354.36 seconds
bluezmakeextell               PASS      120.09 seconds
IncrementalBuild              PASS      1417.64 seconds
ScanBuild                     PASS      998.78 seconds



---
Regards,
Linux Bluetooth

Re: [PATCH BlueZ v1] hog-lib: Fix passing wrong parameters to bt_uhid_get_report_reply

[patchwork-bot+bluetooth]

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Mon, 24 Jun 2024 16:13:24 -0400 you wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> 
> The parameters of bt_uhid_get_report_reply are number followed by
> status, not status followed by number, so the order needs to be
> swapped.
> 
> Fixes: https://github.com/bluez/bluez/issues/880
> 
> [...]

Here is the summary with links:
  - [BlueZ,v1] hog-lib: Fix passing wrong parameters to bt_uhid_get_report_reply
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=5ebaeab4164f

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html