* [PATCH] Bluetooth: btusb: Add Realtek MT7925 support ID 0x13d3:0x3608
@ 2024-08-21 11:08 Pavel Nikulin
2024-08-21 14:50 ` patchwork-bot+bluetooth
2024-08-22 5:53 ` Chris Lu (陸稚泓)
0 siblings, 2 replies; 6+ messages in thread
From: Pavel Nikulin @ 2024-08-21 11:08 UTC (permalink / raw)
To: marcel, luiz.dentz, linux-bluetooth, linux-kernel; +Cc: Pavel Nikulin
Add the support ID (0x13d3, 0x3608) to usb_device_id table for
Realtek MT7925B14L found on AW-EM637 WiFi+BT modules in 2024 Asus laptops.
The device info from /sys/kernel/debug/usb/devices as below.
T: Bus=03 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 2 Spd=480 MxCh= 0
D: Ver= 2.10 Cls=ef(misc ) Sub=02 Prot=01 MxPS=64 #Cfgs= 1
P: Vendor=13d3 ProdID=3608 Rev= 1.00
S: Manufacturer=MediaTek Inc.
S: Product=Wireless_Device
S: SerialNumber=000000000
C:* #Ifs= 3 Cfg#= 1 Atr=e0 MxPwr=100mA
A: FirstIf#= 0 IfCount= 3 Cls=e0(wlcon) Sub=01 Prot=01
I:* If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=81(I) Atr=03(Int.) MxPS= 16 Ivl=125us
E: Ad=82(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
E: Ad=02(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
I:* If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=83(I) Atr=01(Isoc) MxPS= 0 Ivl=1ms
E: Ad=03(O) Atr=01(Isoc) MxPS= 0 Ivl=1ms
I: If#= 1 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=83(I) Atr=01(Isoc) MxPS= 9 Ivl=1ms
E: Ad=03(O) Atr=01(Isoc) MxPS= 9 Ivl=1ms
I: If#= 1 Alt= 2 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=83(I) Atr=01(Isoc) MxPS= 17 Ivl=1ms
E: Ad=03(O) Atr=01(Isoc) MxPS= 17 Ivl=1ms
I: If#= 1 Alt= 3 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=83(I) Atr=01(Isoc) MxPS= 25 Ivl=1ms
E: Ad=03(O) Atr=01(Isoc) MxPS= 25 Ivl=1ms
I: If#= 1 Alt= 4 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=83(I) Atr=01(Isoc) MxPS= 33 Ivl=1ms
E: Ad=03(O) Atr=01(Isoc) MxPS= 33 Ivl=1ms
I: If#= 1 Alt= 5 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=83(I) Atr=01(Isoc) MxPS= 49 Ivl=1ms
E: Ad=03(O) Atr=01(Isoc) MxPS= 49 Ivl=1ms
I: If#= 1 Alt= 6 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=83(I) Atr=01(Isoc) MxPS= 63 Ivl=1ms
E: Ad=03(O) Atr=01(Isoc) MxPS= 63 Ivl=1ms
I: If#= 2 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=8a(I) Atr=03(Int.) MxPS= 64 Ivl=125us
E: Ad=0a(O) Atr=03(Int.) MxPS= 64 Ivl=125us
I:* If#= 2 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=8a(I) Atr=03(Int.) MxPS= 512 Ivl=125us
E: Ad=0a(O) Atr=03(Int.) MxPS= 512 Ivl=125us
Signed-off-by: Pavel Nikulin <pavel@noa-labs.com>
---
drivers/bluetooth/btusb.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index bb698ca98..df0d2e4ab 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -627,6 +627,8 @@ static const struct usb_device_id quirks_table[] = {
BTUSB_WIDEBAND_SPEECH },
{ USB_DEVICE(0x13d3, 0x3604), .driver_info = BTUSB_MEDIATEK |
BTUSB_WIDEBAND_SPEECH },
+ { USB_DEVICE(0x13d3, 0x3608), .driver_info = BTUSB_MEDIATEK |
+ BTUSB_WIDEBAND_SPEECH },
/* Additional Realtek 8723AE Bluetooth devices */
{ USB_DEVICE(0x0930, 0x021d), .driver_info = BTUSB_REALTEK },
--
2.44.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] Bluetooth: btusb: Add Realtek MT7925 support ID 0x13d3:0x3608
2024-08-21 11:08 [PATCH] Bluetooth: btusb: Add Realtek MT7925 support ID 0x13d3:0x3608 Pavel Nikulin
@ 2024-08-21 14:50 ` patchwork-bot+bluetooth
2024-08-22 5:53 ` Chris Lu (陸稚泓)
1 sibling, 0 replies; 6+ messages in thread
From: patchwork-bot+bluetooth @ 2024-08-21 14:50 UTC (permalink / raw)
To: Pavel Nikulin; +Cc: marcel, luiz.dentz, linux-bluetooth, linux-kernel
Hello:
This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:
On Wed, 21 Aug 2024 15:08:56 +0400 you wrote:
> Add the support ID (0x13d3, 0x3608) to usb_device_id table for
> Realtek MT7925B14L found on AW-EM637 WiFi+BT modules in 2024 Asus laptops.
>
> The device info from /sys/kernel/debug/usb/devices as below.
>
> T: Bus=03 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 2 Spd=480 MxCh= 0
> D: Ver= 2.10 Cls=ef(misc ) Sub=02 Prot=01 MxPS=64 #Cfgs= 1
> P: Vendor=13d3 ProdID=3608 Rev= 1.00
> S: Manufacturer=MediaTek Inc.
> S: Product=Wireless_Device
> S: SerialNumber=000000000
> C:* #Ifs= 3 Cfg#= 1 Atr=e0 MxPwr=100mA
> A: FirstIf#= 0 IfCount= 3 Cls=e0(wlcon) Sub=01 Prot=01
> I:* If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> E: Ad=81(I) Atr=03(Int.) MxPS= 16 Ivl=125us
> E: Ad=82(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> E: Ad=02(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> I:* If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> E: Ad=83(I) Atr=01(Isoc) MxPS= 0 Ivl=1ms
> E: Ad=03(O) Atr=01(Isoc) MxPS= 0 Ivl=1ms
> I: If#= 1 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> E: Ad=83(I) Atr=01(Isoc) MxPS= 9 Ivl=1ms
> E: Ad=03(O) Atr=01(Isoc) MxPS= 9 Ivl=1ms
> I: If#= 1 Alt= 2 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> E: Ad=83(I) Atr=01(Isoc) MxPS= 17 Ivl=1ms
> E: Ad=03(O) Atr=01(Isoc) MxPS= 17 Ivl=1ms
> I: If#= 1 Alt= 3 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> E: Ad=83(I) Atr=01(Isoc) MxPS= 25 Ivl=1ms
> E: Ad=03(O) Atr=01(Isoc) MxPS= 25 Ivl=1ms
> I: If#= 1 Alt= 4 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> E: Ad=83(I) Atr=01(Isoc) MxPS= 33 Ivl=1ms
> E: Ad=03(O) Atr=01(Isoc) MxPS= 33 Ivl=1ms
> I: If#= 1 Alt= 5 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> E: Ad=83(I) Atr=01(Isoc) MxPS= 49 Ivl=1ms
> E: Ad=03(O) Atr=01(Isoc) MxPS= 49 Ivl=1ms
> I: If#= 1 Alt= 6 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> E: Ad=83(I) Atr=01(Isoc) MxPS= 63 Ivl=1ms
> E: Ad=03(O) Atr=01(Isoc) MxPS= 63 Ivl=1ms
> I: If#= 2 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> E: Ad=8a(I) Atr=03(Int.) MxPS= 64 Ivl=125us
> E: Ad=0a(O) Atr=03(Int.) MxPS= 64 Ivl=125us
> I:* If#= 2 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> E: Ad=8a(I) Atr=03(Int.) MxPS= 512 Ivl=125us
> E: Ad=0a(O) Atr=03(Int.) MxPS= 512 Ivl=125us
>
> [...]
Here is the summary with links:
- Bluetooth: btusb: Add Realtek MT7925 support ID 0x13d3:0x3608
https://git.kernel.org/bluetooth/bluetooth-next/c/595d19e827a0
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Bluetooth: btusb: Add Realtek MT7925 support ID 0x13d3:0x3608
2024-08-21 11:08 [PATCH] Bluetooth: btusb: Add Realtek MT7925 support ID 0x13d3:0x3608 Pavel Nikulin
2024-08-21 14:50 ` patchwork-bot+bluetooth
@ 2024-08-22 5:53 ` Chris Lu (陸稚泓)
2024-08-22 21:09 ` Pavel Nikulin
1 sibling, 1 reply; 6+ messages in thread
From: Chris Lu (陸稚泓) @ 2024-08-22 5:53 UTC (permalink / raw)
To: luiz.dentz@gmail.com, pavel@noa-labs.com
Cc: marcel@holtmann.org, linux-kernel@vger.kernel.org,
linux-mediatek@lists.infradead.org,
Deren Wu (武德仁),
linux-bluetooth@vger.kernel.org, johan.hedberg@gmail.com,
Steve Lee (李視誠), Sean Wang,
Aaron Hou (侯俊仰)
Hi Luiz and Pavel,
I think these is something wrong to the title and content of this
patch. MT7925 is an connectivity IC from Mediatek rather than Realtek.
Although this patch has been accpeted and merged to the next tree, I'm
wondering if the typo can still be fixed? I'm afraid that such error
could cause some misunderstanding to users.
Thanks a lot!
BRs,
Chris
On Wed, 2024-08-21 at 15:08 +0400, Pavel Nikulin wrote:
> Add the support ID (0x13d3, 0x3608) to usb_device_id table for
> Realtek MT7925B14L found on AW-EM637 WiFi+BT modules in 2024 Asus
> laptops.
>
> The device info from /sys/kernel/debug/usb/devices as below.
>
> T: Bus=03 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 2 Spd=480 MxCh= 0
> D: Ver= 2.10 Cls=ef(misc ) Sub=02 Prot=01 MxPS=64 #Cfgs= 1
> P: Vendor=13d3 ProdID=3608 Rev= 1.00
> S: Manufacturer=MediaTek Inc.
> S: Product=Wireless_Device
> S: SerialNumber=000000000
> C:* #Ifs= 3 Cfg#= 1 Atr=e0 MxPwr=100mA
> A: FirstIf#= 0 IfCount= 3 Cls=e0(wlcon) Sub=01 Prot=01
> I:* If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> E: Ad=81(I) Atr=03(Int.) MxPS= 16 Ivl=125us
> E: Ad=82(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> E: Ad=02(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> I:* If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> E: Ad=83(I) Atr=01(Isoc) MxPS= 0 Ivl=1ms
> E: Ad=03(O) Atr=01(Isoc) MxPS= 0 Ivl=1ms
> I: If#= 1 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> E: Ad=83(I) Atr=01(Isoc) MxPS= 9 Ivl=1ms
> E: Ad=03(O) Atr=01(Isoc) MxPS= 9 Ivl=1ms
> I: If#= 1 Alt= 2 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> E: Ad=83(I) Atr=01(Isoc) MxPS= 17 Ivl=1ms
> E: Ad=03(O) Atr=01(Isoc) MxPS= 17 Ivl=1ms
> I: If#= 1 Alt= 3 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> E: Ad=83(I) Atr=01(Isoc) MxPS= 25 Ivl=1ms
> E: Ad=03(O) Atr=01(Isoc) MxPS= 25 Ivl=1ms
> I: If#= 1 Alt= 4 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> E: Ad=83(I) Atr=01(Isoc) MxPS= 33 Ivl=1ms
> E: Ad=03(O) Atr=01(Isoc) MxPS= 33 Ivl=1ms
> I: If#= 1 Alt= 5 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> E: Ad=83(I) Atr=01(Isoc) MxPS= 49 Ivl=1ms
> E: Ad=03(O) Atr=01(Isoc) MxPS= 49 Ivl=1ms
> I: If#= 1 Alt= 6 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> E: Ad=83(I) Atr=01(Isoc) MxPS= 63 Ivl=1ms
> E: Ad=03(O) Atr=01(Isoc) MxPS= 63 Ivl=1ms
> I: If#= 2 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> E: Ad=8a(I) Atr=03(Int.) MxPS= 64 Ivl=125us
> E: Ad=0a(O) Atr=03(Int.) MxPS= 64 Ivl=125us
> I:* If#= 2 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> E: Ad=8a(I) Atr=03(Int.) MxPS= 512 Ivl=125us
> E: Ad=0a(O) Atr=03(Int.) MxPS= 512 Ivl=125us
>
> Signed-off-by: Pavel Nikulin <pavel@noa-labs.com>
> ---
> drivers/bluetooth/btusb.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index bb698ca98..df0d2e4ab 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -627,6 +627,8 @@ static const struct usb_device_id quirks_table[]
> = {
> BTUSB_WIDEBAND_SPE
> ECH },
> { USB_DEVICE(0x13d3, 0x3604), .driver_info = BTUSB_MEDIATEK |
> BTUSB_WIDEBAND_SPE
> ECH },
> + { USB_DEVICE(0x13d3, 0x3608), .driver_info = BTUSB_MEDIATEK |
> + BTUSB_WIDEBAND_SPE
> ECH },
>
> /* Additional Realtek 8723AE Bluetooth devices */
> { USB_DEVICE(0x0930, 0x021d), .driver_info = BTUSB_REALTEK },
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Bluetooth: btusb: Add Realtek MT7925 support ID 0x13d3:0x3608
2024-08-22 5:53 ` Chris Lu (陸稚泓)
@ 2024-08-22 21:09 ` Pavel Nikulin
2024-08-22 21:42 ` Luiz Augusto von Dentz
0 siblings, 1 reply; 6+ messages in thread
From: Pavel Nikulin @ 2024-08-22 21:09 UTC (permalink / raw)
To: Chris Lu (陸稚泓)
Cc: luiz.dentz@gmail.com, marcel@holtmann.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
Deren Wu (武德仁),
linux-bluetooth@vger.kernel.org, johan.hedberg@gmail.com,
Steve Lee (李視誠), Sean Wang,
Aaron Hou (侯俊仰)
Oh my, how I missed that.
I think a commit can be undone, and the same patch with a correct
commit message submitted again. Somebody with access will have to
revert it.
Pavel Nikulin
Senior Engineer
+971 52 386 6738
pavel@noa-labs.com
On Thu, Aug 22, 2024 at 9:54 AM Chris Lu (陸稚泓) <Chris.Lu@mediatek.com> wrote:
>
> Hi Luiz and Pavel,
>
> I think these is something wrong to the title and content of this
> patch. MT7925 is an connectivity IC from Mediatek rather than Realtek.
>
> Although this patch has been accpeted and merged to the next tree, I'm
> wondering if the typo can still be fixed? I'm afraid that such error
> could cause some misunderstanding to users.
>
> Thanks a lot!
>
> BRs,
> Chris
>
> On Wed, 2024-08-21 at 15:08 +0400, Pavel Nikulin wrote:
> > Add the support ID (0x13d3, 0x3608) to usb_device_id table for
> > Realtek MT7925B14L found on AW-EM637 WiFi+BT modules in 2024 Asus
> > laptops.
> >
> > The device info from /sys/kernel/debug/usb/devices as below.
> >
> > T: Bus=03 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 2 Spd=480 MxCh= 0
> > D: Ver= 2.10 Cls=ef(misc ) Sub=02 Prot=01 MxPS=64 #Cfgs= 1
> > P: Vendor=13d3 ProdID=3608 Rev= 1.00
> > S: Manufacturer=MediaTek Inc.
> > S: Product=Wireless_Device
> > S: SerialNumber=000000000
> > C:* #Ifs= 3 Cfg#= 1 Atr=e0 MxPwr=100mA
> > A: FirstIf#= 0 IfCount= 3 Cls=e0(wlcon) Sub=01 Prot=01
> > I:* If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> > E: Ad=81(I) Atr=03(Int.) MxPS= 16 Ivl=125us
> > E: Ad=82(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > E: Ad=02(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > I:* If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> > E: Ad=83(I) Atr=01(Isoc) MxPS= 0 Ivl=1ms
> > E: Ad=03(O) Atr=01(Isoc) MxPS= 0 Ivl=1ms
> > I: If#= 1 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> > E: Ad=83(I) Atr=01(Isoc) MxPS= 9 Ivl=1ms
> > E: Ad=03(O) Atr=01(Isoc) MxPS= 9 Ivl=1ms
> > I: If#= 1 Alt= 2 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> > E: Ad=83(I) Atr=01(Isoc) MxPS= 17 Ivl=1ms
> > E: Ad=03(O) Atr=01(Isoc) MxPS= 17 Ivl=1ms
> > I: If#= 1 Alt= 3 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> > E: Ad=83(I) Atr=01(Isoc) MxPS= 25 Ivl=1ms
> > E: Ad=03(O) Atr=01(Isoc) MxPS= 25 Ivl=1ms
> > I: If#= 1 Alt= 4 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> > E: Ad=83(I) Atr=01(Isoc) MxPS= 33 Ivl=1ms
> > E: Ad=03(O) Atr=01(Isoc) MxPS= 33 Ivl=1ms
> > I: If#= 1 Alt= 5 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> > E: Ad=83(I) Atr=01(Isoc) MxPS= 49 Ivl=1ms
> > E: Ad=03(O) Atr=01(Isoc) MxPS= 49 Ivl=1ms
> > I: If#= 1 Alt= 6 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> > E: Ad=83(I) Atr=01(Isoc) MxPS= 63 Ivl=1ms
> > E: Ad=03(O) Atr=01(Isoc) MxPS= 63 Ivl=1ms
> > I: If#= 2 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> > E: Ad=8a(I) Atr=03(Int.) MxPS= 64 Ivl=125us
> > E: Ad=0a(O) Atr=03(Int.) MxPS= 64 Ivl=125us
> > I:* If#= 2 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> > E: Ad=8a(I) Atr=03(Int.) MxPS= 512 Ivl=125us
> > E: Ad=0a(O) Atr=03(Int.) MxPS= 512 Ivl=125us
> >
> > Signed-off-by: Pavel Nikulin <pavel@noa-labs.com>
> > ---
> > drivers/bluetooth/btusb.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> > index bb698ca98..df0d2e4ab 100644
> > --- a/drivers/bluetooth/btusb.c
> > +++ b/drivers/bluetooth/btusb.c
> > @@ -627,6 +627,8 @@ static const struct usb_device_id quirks_table[]
> > = {
> > BTUSB_WIDEBAND_SPE
> > ECH },
> > { USB_DEVICE(0x13d3, 0x3604), .driver_info = BTUSB_MEDIATEK |
> > BTUSB_WIDEBAND_SPE
> > ECH },
> > +{ USB_DEVICE(0x13d3, 0x3608), .driver_info = BTUSB_MEDIATEK |
> > + BTUSB_WIDEBAND_SPE
> > ECH },
> >
> > /* Additional Realtek 8723AE Bluetooth devices */
> > { USB_DEVICE(0x0930, 0x021d), .driver_info = BTUSB_REALTEK },
>
> ************* MEDIATEK Confidentiality Notice ********************
> The information contained in this e-mail message (including any
> attachments) may be confidential, proprietary, privileged, or otherwise
> exempt from disclosure under applicable laws. It is intended to be
> conveyed only to the designated recipient(s). Any use, dissemination,
> distribution, printing, retaining or copying of this e-mail (including its
> attachments) by unintended recipient(s) is strictly prohibited and may
> be unlawful. If you are not an intended recipient of this e-mail, or believe
> that you have received this e-mail in error, please notify the sender
> immediately (by replying to this e-mail), delete any and all copies of
> this e-mail (including any attachments) from your system, and do not
> disclose the content of this e-mail to any other person. Thank you!
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Bluetooth: btusb: Add Realtek MT7925 support ID 0x13d3:0x3608
2024-08-22 21:09 ` Pavel Nikulin
@ 2024-08-22 21:42 ` Luiz Augusto von Dentz
2024-08-26 12:03 ` Pavel Nikulin
0 siblings, 1 reply; 6+ messages in thread
From: Luiz Augusto von Dentz @ 2024-08-22 21:42 UTC (permalink / raw)
To: Pavel Nikulin
Cc: Chris Lu (陸稚泓), marcel@holtmann.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
Deren Wu (武德仁),
linux-bluetooth@vger.kernel.org, johan.hedberg@gmail.com,
Steve Lee (李視誠), Sean Wang,
Aaron Hou (侯俊仰)
Hi Pavel,
On Thu, Aug 22, 2024 at 5:09 PM Pavel Nikulin <pavel@noa-labs.com> wrote:
>
> Oh my, how I missed that.
>
> I think a commit can be undone, and the same patch with a correct
> commit message submitted again. Somebody with access will have to
> revert it.
I will do that once I rebase for the next pull request, it is just a
matter of doing s/Realtek/Mediatek?
>
> Pavel Nikulin
> Senior Engineer
> +971 52 386 6738
> pavel@noa-labs.com
>
>
>
> On Thu, Aug 22, 2024 at 9:54 AM Chris Lu (陸稚泓) <Chris.Lu@mediatek.com> wrote:
> >
> > Hi Luiz and Pavel,
> >
> > I think these is something wrong to the title and content of this
> > patch. MT7925 is an connectivity IC from Mediatek rather than Realtek.
> >
> > Although this patch has been accpeted and merged to the next tree, I'm
> > wondering if the typo can still be fixed? I'm afraid that such error
> > could cause some misunderstanding to users.
> >
> > Thanks a lot!
> >
> > BRs,
> > Chris
> >
> > On Wed, 2024-08-21 at 15:08 +0400, Pavel Nikulin wrote:
> > > Add the support ID (0x13d3, 0x3608) to usb_device_id table for
> > > Realtek MT7925B14L found on AW-EM637 WiFi+BT modules in 2024 Asus
> > > laptops.
> > >
> > > The device info from /sys/kernel/debug/usb/devices as below.
> > >
> > > T: Bus=03 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 2 Spd=480 MxCh= 0
> > > D: Ver= 2.10 Cls=ef(misc ) Sub=02 Prot=01 MxPS=64 #Cfgs= 1
> > > P: Vendor=13d3 ProdID=3608 Rev= 1.00
> > > S: Manufacturer=MediaTek Inc.
> > > S: Product=Wireless_Device
> > > S: SerialNumber=000000000
> > > C:* #Ifs= 3 Cfg#= 1 Atr=e0 MxPwr=100mA
> > > A: FirstIf#= 0 IfCount= 3 Cls=e0(wlcon) Sub=01 Prot=01
> > > I:* If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> > > E: Ad=81(I) Atr=03(Int.) MxPS= 16 Ivl=125us
> > > E: Ad=82(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > > E: Ad=02(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > > I:* If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> > > E: Ad=83(I) Atr=01(Isoc) MxPS= 0 Ivl=1ms
> > > E: Ad=03(O) Atr=01(Isoc) MxPS= 0 Ivl=1ms
> > > I: If#= 1 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> > > E: Ad=83(I) Atr=01(Isoc) MxPS= 9 Ivl=1ms
> > > E: Ad=03(O) Atr=01(Isoc) MxPS= 9 Ivl=1ms
> > > I: If#= 1 Alt= 2 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> > > E: Ad=83(I) Atr=01(Isoc) MxPS= 17 Ivl=1ms
> > > E: Ad=03(O) Atr=01(Isoc) MxPS= 17 Ivl=1ms
> > > I: If#= 1 Alt= 3 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> > > E: Ad=83(I) Atr=01(Isoc) MxPS= 25 Ivl=1ms
> > > E: Ad=03(O) Atr=01(Isoc) MxPS= 25 Ivl=1ms
> > > I: If#= 1 Alt= 4 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> > > E: Ad=83(I) Atr=01(Isoc) MxPS= 33 Ivl=1ms
> > > E: Ad=03(O) Atr=01(Isoc) MxPS= 33 Ivl=1ms
> > > I: If#= 1 Alt= 5 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> > > E: Ad=83(I) Atr=01(Isoc) MxPS= 49 Ivl=1ms
> > > E: Ad=03(O) Atr=01(Isoc) MxPS= 49 Ivl=1ms
> > > I: If#= 1 Alt= 6 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> > > E: Ad=83(I) Atr=01(Isoc) MxPS= 63 Ivl=1ms
> > > E: Ad=03(O) Atr=01(Isoc) MxPS= 63 Ivl=1ms
> > > I: If#= 2 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> > > E: Ad=8a(I) Atr=03(Int.) MxPS= 64 Ivl=125us
> > > E: Ad=0a(O) Atr=03(Int.) MxPS= 64 Ivl=125us
> > > I:* If#= 2 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> > > E: Ad=8a(I) Atr=03(Int.) MxPS= 512 Ivl=125us
> > > E: Ad=0a(O) Atr=03(Int.) MxPS= 512 Ivl=125us
> > >
> > > Signed-off-by: Pavel Nikulin <pavel@noa-labs.com>
> > > ---
> > > drivers/bluetooth/btusb.c | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> > > index bb698ca98..df0d2e4ab 100644
> > > --- a/drivers/bluetooth/btusb.c
> > > +++ b/drivers/bluetooth/btusb.c
> > > @@ -627,6 +627,8 @@ static const struct usb_device_id quirks_table[]
> > > = {
> > > BTUSB_WIDEBAND_SPE
> > > ECH },
> > > { USB_DEVICE(0x13d3, 0x3604), .driver_info = BTUSB_MEDIATEK |
> > > BTUSB_WIDEBAND_SPE
> > > ECH },
> > > +{ USB_DEVICE(0x13d3, 0x3608), .driver_info = BTUSB_MEDIATEK |
> > > + BTUSB_WIDEBAND_SPE
> > > ECH },
> > >
> > > /* Additional Realtek 8723AE Bluetooth devices */
> > > { USB_DEVICE(0x0930, 0x021d), .driver_info = BTUSB_REALTEK },
> >
> > ************* MEDIATEK Confidentiality Notice ********************
> > The information contained in this e-mail message (including any
> > attachments) may be confidential, proprietary, privileged, or otherwise
> > exempt from disclosure under applicable laws. It is intended to be
> > conveyed only to the designated recipient(s). Any use, dissemination,
> > distribution, printing, retaining or copying of this e-mail (including its
> > attachments) by unintended recipient(s) is strictly prohibited and may
> > be unlawful. If you are not an intended recipient of this e-mail, or believe
> > that you have received this e-mail in error, please notify the sender
> > immediately (by replying to this e-mail), delete any and all copies of
> > this e-mail (including any attachments) from your system, and do not
> > disclose the content of this e-mail to any other person. Thank you!
--
Luiz Augusto von Dentz
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Bluetooth: btusb: Add Realtek MT7925 support ID 0x13d3:0x3608
2024-08-22 21:42 ` Luiz Augusto von Dentz
@ 2024-08-26 12:03 ` Pavel Nikulin
0 siblings, 0 replies; 6+ messages in thread
From: Pavel Nikulin @ 2024-08-26 12:03 UTC (permalink / raw)
To: Luiz Augusto von Dentz
Cc: Chris Lu (陸稚泓), marcel@holtmann.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
Deren Wu (武德仁),
linux-bluetooth@vger.kernel.org, johan.hedberg@gmail.com,
Steve Lee (李視誠), Sean Wang,
Aaron Hou (侯俊仰)
Yes, just replace realtek with mediatek, and indicate that it fixes
https://bugzilla.kernel.org/show_bug.cgi?id=219182
Pavel Nikulin
Senior Engineer
+971 52 386 6738
pavel@noa-labs.com
On Fri, Aug 23, 2024 at 1:42 AM Luiz Augusto von Dentz
<luiz.dentz@gmail.com> wrote:
>
> Hi Pavel,
>
> On Thu, Aug 22, 2024 at 5:09 PM Pavel Nikulin <pavel@noa-labs.com> wrote:
> >
> > Oh my, how I missed that.
> >
> > I think a commit can be undone, and the same patch with a correct
> > commit message submitted again. Somebody with access will have to
> > revert it.
>
> I will do that once I rebase for the next pull request, it is just a
> matter of doing s/Realtek/Mediatek?
>
> >
> > Pavel Nikulin
> > Senior Engineer
> > +971 52 386 6738
> > pavel@noa-labs.com
> >
> >
> >
> > On Thu, Aug 22, 2024 at 9:54 AM Chris Lu (陸稚泓) <Chris.Lu@mediatek.com> wrote:
> > >
> > > Hi Luiz and Pavel,
> > >
> > > I think these is something wrong to the title and content of this
> > > patch. MT7925 is an connectivity IC from Mediatek rather than Realtek.
> > >
> > > Although this patch has been accpeted and merged to the next tree, I'm
> > > wondering if the typo can still be fixed? I'm afraid that such error
> > > could cause some misunderstanding to users.
> > >
> > > Thanks a lot!
> > >
> > > BRs,
> > > Chris
> > >
> > > On Wed, 2024-08-21 at 15:08 +0400, Pavel Nikulin wrote:
> > > > Add the support ID (0x13d3, 0x3608) to usb_device_id table for
> > > > Realtek MT7925B14L found on AW-EM637 WiFi+BT modules in 2024 Asus
> > > > laptops.
> > > >
> > > > The device info from /sys/kernel/debug/usb/devices as below.
> > > >
> > > > T: Bus=03 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 2 Spd=480 MxCh= 0
> > > > D: Ver= 2.10 Cls=ef(misc ) Sub=02 Prot=01 MxPS=64 #Cfgs= 1
> > > > P: Vendor=13d3 ProdID=3608 Rev= 1.00
> > > > S: Manufacturer=MediaTek Inc.
> > > > S: Product=Wireless_Device
> > > > S: SerialNumber=000000000
> > > > C:* #Ifs= 3 Cfg#= 1 Atr=e0 MxPwr=100mA
> > > > A: FirstIf#= 0 IfCount= 3 Cls=e0(wlcon) Sub=01 Prot=01
> > > > I:* If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> > > > E: Ad=81(I) Atr=03(Int.) MxPS= 16 Ivl=125us
> > > > E: Ad=82(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > > > E: Ad=02(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > > > I:* If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> > > > E: Ad=83(I) Atr=01(Isoc) MxPS= 0 Ivl=1ms
> > > > E: Ad=03(O) Atr=01(Isoc) MxPS= 0 Ivl=1ms
> > > > I: If#= 1 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> > > > E: Ad=83(I) Atr=01(Isoc) MxPS= 9 Ivl=1ms
> > > > E: Ad=03(O) Atr=01(Isoc) MxPS= 9 Ivl=1ms
> > > > I: If#= 1 Alt= 2 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> > > > E: Ad=83(I) Atr=01(Isoc) MxPS= 17 Ivl=1ms
> > > > E: Ad=03(O) Atr=01(Isoc) MxPS= 17 Ivl=1ms
> > > > I: If#= 1 Alt= 3 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> > > > E: Ad=83(I) Atr=01(Isoc) MxPS= 25 Ivl=1ms
> > > > E: Ad=03(O) Atr=01(Isoc) MxPS= 25 Ivl=1ms
> > > > I: If#= 1 Alt= 4 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> > > > E: Ad=83(I) Atr=01(Isoc) MxPS= 33 Ivl=1ms
> > > > E: Ad=03(O) Atr=01(Isoc) MxPS= 33 Ivl=1ms
> > > > I: If#= 1 Alt= 5 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> > > > E: Ad=83(I) Atr=01(Isoc) MxPS= 49 Ivl=1ms
> > > > E: Ad=03(O) Atr=01(Isoc) MxPS= 49 Ivl=1ms
> > > > I: If#= 1 Alt= 6 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> > > > E: Ad=83(I) Atr=01(Isoc) MxPS= 63 Ivl=1ms
> > > > E: Ad=03(O) Atr=01(Isoc) MxPS= 63 Ivl=1ms
> > > > I: If#= 2 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> > > > E: Ad=8a(I) Atr=03(Int.) MxPS= 64 Ivl=125us
> > > > E: Ad=0a(O) Atr=03(Int.) MxPS= 64 Ivl=125us
> > > > I:* If#= 2 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> > > > E: Ad=8a(I) Atr=03(Int.) MxPS= 512 Ivl=125us
> > > > E: Ad=0a(O) Atr=03(Int.) MxPS= 512 Ivl=125us
> > > >
> > > > Signed-off-by: Pavel Nikulin <pavel@noa-labs.com>
> > > > ---
> > > > drivers/bluetooth/btusb.c | 2 ++
> > > > 1 file changed, 2 insertions(+)
> > > >
> > > > diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> > > > index bb698ca98..df0d2e4ab 100644
> > > > --- a/drivers/bluetooth/btusb.c
> > > > +++ b/drivers/bluetooth/btusb.c
> > > > @@ -627,6 +627,8 @@ static const struct usb_device_id quirks_table[]
> > > > = {
> > > > BTUSB_WIDEBAND_SPE
> > > > ECH },
> > > > { USB_DEVICE(0x13d3, 0x3604), .driver_info = BTUSB_MEDIATEK |
> > > > BTUSB_WIDEBAND_SPE
> > > > ECH },
> > > > +{ USB_DEVICE(0x13d3, 0x3608), .driver_info = BTUSB_MEDIATEK |
> > > > + BTUSB_WIDEBAND_SPE
> > > > ECH },
> > > >
> > > > /* Additional Realtek 8723AE Bluetooth devices */
> > > > { USB_DEVICE(0x0930, 0x021d), .driver_info = BTUSB_REALTEK },
> > >
> > > ************* MEDIATEK Confidentiality Notice ********************
> > > The information contained in this e-mail message (including any
> > > attachments) may be confidential, proprietary, privileged, or otherwise
> > > exempt from disclosure under applicable laws. It is intended to be
> > > conveyed only to the designated recipient(s). Any use, dissemination,
> > > distribution, printing, retaining or copying of this e-mail (including its
> > > attachments) by unintended recipient(s) is strictly prohibited and may
> > > be unlawful. If you are not an intended recipient of this e-mail, or believe
> > > that you have received this e-mail in error, please notify the sender
> > > immediately (by replying to this e-mail), delete any and all copies of
> > > this e-mail (including any attachments) from your system, and do not
> > > disclose the content of this e-mail to any other person. Thank you!
>
>
>
> --
> Luiz Augusto von Dentz
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-08-26 12:03 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-21 11:08 [PATCH] Bluetooth: btusb: Add Realtek MT7925 support ID 0x13d3:0x3608 Pavel Nikulin
2024-08-21 14:50 ` patchwork-bot+bluetooth
2024-08-22 5:53 ` Chris Lu (陸稚泓)
2024-08-22 21:09 ` Pavel Nikulin
2024-08-22 21:42 ` Luiz Augusto von Dentz
2024-08-26 12:03 ` Pavel Nikulin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox