[PATCH] Bluetooth: bnep: fix wild-memory-access in proto_unregister

[PATCH] Bluetooth: bnep: fix wild-memory-access in proto_unregister

[Ye Bin]

From: Ye Bin <yebin10@huawei.com>

There's issue as follows:
  KASAN: maybe wild-memory-access in range [0xdead...108-0xdead...10f]
  CPU: 3 UID: 0 PID: 2805 Comm: rmmod Tainted: G        W
  RIP: 0010:proto_unregister+0xee/0x400
  Call Trace:
   <TASK>
   __do_sys_delete_module+0x318/0x580
   do_syscall_64+0xc1/0x1d0
   entry_SYSCALL_64_after_hwframe+0x77/0x7f

As bnep_init() ignore bnep_sock_init()'s return value, and bnep_sock_init()
will cleanup all resource. Then when remove bnep module will call
bnep_sock_cleanup() to cleanup sock's resource.
To solve above issue just return bnep_sock_init()'s return value in
bnep_exit().

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Ye Bin <yebin10@huawei.com>
---
 net/bluetooth/bnep/core.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/net/bluetooth/bnep/core.c b/net/bluetooth/bnep/core.c
index a3bc0934cc13..d44987d4515c 100644
--- a/net/bluetooth/bnep/core.c
+++ b/net/bluetooth/bnep/core.c
@@ -745,8 +745,7 @@ static int __init bnep_init(void)
 	if (flt[0])
 		BT_INFO("BNEP filters: %s", flt);
 
-	bnep_sock_init();
-	return 0;
+	return bnep_sock_init();
 }
 
 static void __exit bnep_exit(void)
-- 
2.34.1

Re: [PATCH] Bluetooth: bnep: fix wild-memory-access in proto_unregister

[patchwork-bot+bluetooth]

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Mon, 14 Oct 2024 17:07:08 +0800 you wrote:
> From: Ye Bin <yebin10@huawei.com>
> 
> There's issue as follows:
>   KASAN: maybe wild-memory-access in range [0xdead...108-0xdead...10f]
>   CPU: 3 UID: 0 PID: 2805 Comm: rmmod Tainted: G        W
>   RIP: 0010:proto_unregister+0xee/0x400
>   Call Trace:
>    <TASK>
>    __do_sys_delete_module+0x318/0x580
>    do_syscall_64+0xc1/0x1d0
>    entry_SYSCALL_64_after_hwframe+0x77/0x7f
> 
> [...]

Here is the summary with links:
  - Bluetooth: bnep: fix wild-memory-access in proto_unregister
    https://git.kernel.org/bluetooth/bluetooth-next/c/7902a76b54e3

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html