linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Szymon Janc <szymon.janc@codecoup.pl>
To: Jaganath K <jaganath.k.os@gmail.com>
Cc: "Łukasz Rymanowski" <lukasz.rymanowski@codecoup.pl>,
	"Luiz Augusto von Dentz" <luiz.dentz@gmail.com>,
	"open list:BLUETOOTH DRIVERS" <linux-bluetooth@vger.kernel.org>,
	"Jaganath Kanakkassery" <jaganathx.kanakkassery@intel.com>
Subject: Re: [PATCH 2/4 v4] doc/mgmt-api: Add support for Set Phy Configuration command
Date: Wed, 21 Feb 2018 08:47:49 +0100	[thread overview]
Message-ID: <1731980.7kiFeXdM4S@ix> (raw)
In-Reply-To: <CAJzH+boewxsR-3mBwL1Tn6-u4MotqLeww2FXiw4NKe7QJViizQ@mail.gmail.com>

Hi,

On Wednesday, 21 February 2018 07:09:49 CET Jaganath K wrote:
> >>>>>>> I think there is a limitation with current API proposal, user cannot
> >>>>>>> do extended scanning in only 1M (to scan secondary channel in 1M)
> >>>>>>> since with 1M we will switch to legacy scanning.
> >>>>>> 
> >>>>>> Why do we have to switch to legacy scanning for 1M? It seems it would
> >>>>>> be possible to use extended scanning whenever it is supported
> >>>>>> regardless of the PHY, or perhaps the spec imposes limitations to
> >>>>>> certain PHYs? Coded perhaps?
> >>>>> 
> >>>>> The idea is to enable application to use legacy scanning even if
> >>>>> controller supports
> >>>>> extended. (ie if application dont want extended features to be used)
> >>>>> and unlike advertising
> >>>>> legacy scanning can not be emulated using extended scanning.
> >>>> 
> >>>> Bluetooth controller which is doing extended scanning will report
> >>>> legacy
> >>>> advertisings as well. It will just use Extended Advertising Report
> >>>> Event for this purpose and Linux Kernel should handle it.
> >>> 
> >>> Yes, but the idea here is more on perspective of power savings
> >>> where in application dont want to scan on secondary channels itself and
> >>> API should support it.
> > 
> > Then maybe there should not be dependence between this command and
> > scan/connect. Actually I do not understand why we have it, need to check
> > previous conversation.
> > 
> >> I would agree if this affects passive scanning, but in that case we
> >> can probably program the scan type when adding a device or only really
> >> scan on primary channel since the purpose is to connect it doesn't
> >> really matter what is on the secondary channels, for active scanning I
> >> don't think we would be saving that much power since that should be
> >> short-lived so Im not sure we should bother with it.
> > 
> > In extended advertising there is no such thing as connectable and
> > scannable at the same time
> > When device is connectable, then address and optionally advertising
> > data is in the aux ptr (secondary channel)
> > 
> > Please also remember that it is up to controller to connect / scan on
> > secondary PHY based on primary PHY provided by host.
> > Meaning, host controls primary channel only, which can be 1M or Coded.
> > Rest is up to controller and data in AUX_PTR of ADV_EXT_IND
> 
> I would wait for Marcel's comments here.

FWIW Apache Mynewt (master, soon to be released 1.4) has full support for 
Extended Advertising and Scanning including all PHYs (on nRF52840) and data 
fragmentation. You can build blehci app and use it with BlueZ for testing.

-- 
pozdrawiam
Szymon Janc



  reply	other threads:[~2018-02-21  7:47 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-29  6:52 [PATCH 0/4 v4] LE New PHYs kernel interfaces Jaganath Kanakkassery
2017-11-29  6:52 ` [PATCH 1/4 v4] doc/mgmt-api: Add support for Get PHY Configuration command Jaganath Kanakkassery
2018-02-09 13:05   ` Luiz Augusto von Dentz
2018-02-09 14:43     ` Jaganath K
2017-11-29  6:52 ` [PATCH 2/4 v4] doc/mgmt-api: Add support for Set Phy " Jaganath Kanakkassery
2018-02-16  3:40   ` Jaganath K
2018-02-19  8:47     ` Luiz Augusto von Dentz
2018-02-19  9:25       ` Jaganath K
2018-02-19  9:58         ` Łukasz Rymanowski
2018-02-19 10:09           ` Jaganath K
2018-02-19 10:31             ` Luiz Augusto von Dentz
2018-02-19 11:07               ` Łukasz Rymanowski
2018-02-21  6:09                 ` Jaganath K
2018-02-21  7:47                   ` Szymon Janc [this message]
2018-02-22  5:49                     ` Jaganath K
2017-11-29  6:52 ` [PATCH 3/4 v4] doc/mgmt-api: Add advertising phys support to flags Jaganath Kanakkassery
2018-02-27 13:11   ` Marcel Holtmann
2017-11-29  6:52 ` [PATCH 4/4] doc/mgmt-api: Update Duration Parameter description of Add Advertising Jaganath Kanakkassery

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1731980.7kiFeXdM4S@ix \
    --to=szymon.janc@codecoup.pl \
    --cc=jaganath.k.os@gmail.com \
    --cc=jaganathx.kanakkassery@intel.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    --cc=lukasz.rymanowski@codecoup.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).