[PATCH 1/3] shared/ad: fix -std=c23 build failure

[PATCH 1/3] shared/ad: fix -std=c23 build failure

[Rudi Heitbaum]

gcc-15 switched to -std=c23 by default:

    https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=55e3bd376b2214e200fa76d12b67ff259b06c212

As a result `bluez` fails the build as:

    src/shared/ad.c:1090:24: error: incompatible types when returning type '_Bool' but 'const char *' was expected
     1090 |                 return false;
          |                        ^~~~~

Signed-off-by: Rudi Heitbaum <rudi@heitbaum.com>
---
 src/shared/ad.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/shared/ad.c b/src/shared/ad.c
index d08ce7af9..dac381bbe 100644
--- a/src/shared/ad.c
+++ b/src/shared/ad.c
@@ -1087,7 +1087,7 @@ bool bt_ad_add_name(struct bt_ad *ad, const char *name)
 const char *bt_ad_get_name(struct bt_ad *ad)
 {
 	if (!ad)
-		return false;
+		return NULL;
 
 	return ad->name;
 }
-- 
2.43.0

RE: [1/3] shared/ad: fix -std=c23 build failure

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 2502 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=911278

---Test result---

Test Summary:
CheckPatch                    PENDING   0.38 seconds
GitLint                       PENDING   0.31 seconds
BuildEll                      PASS      20.86 seconds
BluezMake                     PASS      1659.99 seconds
MakeCheck                     PASS      13.31 seconds
MakeDistcheck                 PASS      160.21 seconds
CheckValgrind                 PASS      215.87 seconds
CheckSmatch                   WARNING   274.51 seconds
bluezmakeextell               PASS      99.59 seconds
IncrementalBuild              PENDING   0.49 seconds
ScanBuild                     PASS      857.14 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: CheckSmatch - WARNING
Desc: Run smatch tool with source
Output:
src/shared/shell.c: note: in included file (through /usr/include/readline/readline.h):src/shared/shell.c: note: in included file (through /usr/include/readline/readline.h):src/shared/shell.c: note: in included file (through /usr/include/readline/readline.h):src/shared/gatt-helpers.c:768:31: warning: Variable length array is used.src/shared/gatt-helpers.c:830:31: warning: Variable length array is used.src/shared/gatt-helpers.c:1323:31: warning: Variable length array is used.src/shared/gatt-helpers.c:1354:23: warning: Variable length array is used.src/shared/gatt-helpers.c:768:31: warning: Variable length array is used.src/shared/gatt-helpers.c:830:31: warning: Variable length array is used.src/shared/gatt-helpers.c:1323:31: warning: Variable length array is used.src/shared/gatt-helpers.c:1354:23: warning: Variable length array is used.src/shared/gatt-helpers.c:768:31: warning: Variable length array is used.src/shared/gatt-helpers.c:830:31: warning: Variable length array is used.src/shared/gatt-helpers.c:1323:31: warning: Variable length array is used.src/shared/gatt-helpers.c:1354:23: warning: Variable length array is used.
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth

Re: [PATCH 1/3] shared/ad: fix -std=c23 build failure

[patchwork-bot+bluetooth]

Hello:

This series was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Wed, 20 Nov 2024 13:02:56 +0000 you wrote:
> gcc-15 switched to -std=c23 by default:
> 
>     https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=55e3bd376b2214e200fa76d12b67ff259b06c212
> 
> As a result `bluez` fails the build as:
> 
>     src/shared/ad.c:1090:24: error: incompatible types when returning type '_Bool' but 'const char *' was expected
>      1090 |                 return false;
>           |                        ^~~~~
> 
> [...]

Here is the summary with links:
  - [1/3] shared/ad: fix -std=c23 build failure
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=da5b5b0ecb1e
  - [2/3] shared/shell: fix -std=c23 build failure
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=4d60826865c7
  - [3/3] shared/gatt-helpers: fix -std=c23 build failure
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=6f3111eb680d

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html