[PATCH BlueZ] device: Clear pending_wake_allowed on error

[PATCH BlueZ] device: Clear pending_wake_allowed on error

[Ludovico de Nittis]

If setting WakeAllowed fails, we should unset the `pending_wake_allowed`
property, or subsequent requests will be rejected due to another
"Property change in progress".

Fixes: https://github.com/bluez/bluez/issues/1047
---
 src/device.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/device.c b/src/device.c
index 24ef3d779..e8bff718c 100644
--- a/src/device.c
+++ b/src/device.c
@@ -1574,6 +1574,7 @@ static void set_wake_allowed_complete(uint8_t status, uint16_t length,
 						      mgmt_errstr(status));
 			dev->wake_id = -1U;
 		}
+		dev->pending_wake_allowed = FALSE;
 		return;
 	}
 
-- 
2.47.1

RE: [BlueZ] device: Clear pending_wake_allowed on error

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1260 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=924349

---Test result---

Test Summary:
CheckPatch                    PENDING   0.20 seconds
GitLint                       PENDING   0.25 seconds
BuildEll                      PASS      20.59 seconds
BluezMake                     PASS      1509.98 seconds
MakeCheck                     PASS      13.05 seconds
MakeDistcheck                 PASS      156.96 seconds
CheckValgrind                 PASS      213.77 seconds
CheckSmatch                   PASS      272.33 seconds
bluezmakeextell               PASS      98.24 seconds
IncrementalBuild              PENDING   0.30 seconds
ScanBuild                     PASS      863.29 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth

Re: [PATCH BlueZ] device: Clear pending_wake_allowed on error

[patchwork-bot+bluetooth]

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Fri, 10 Jan 2025 18:31:46 +0100 you wrote:
> If setting WakeAllowed fails, we should unset the `pending_wake_allowed`
> property, or subsequent requests will be rejected due to another
> "Property change in progress".
> 
> Fixes: https://github.com/bluez/bluez/issues/1047
> ---
>  src/device.c | 1 +
>  1 file changed, 1 insertion(+)

Here is the summary with links:
  - [BlueZ] device: Clear pending_wake_allowed on error
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=2ee08ffd4d46

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html