[PATCH BlueZ v1] shared/bap: Fix state transition of sink for disable operation

[PATCH BlueZ v1] shared/bap: Fix state transition of sink for disable operation

[Luiz Augusto von Dentz]

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

This fixes a regression introduced by 173045553c15
("bap: Fix not generating releasing state") where the Disable operation
no long caused the transition to QoS configured for Sink, as per ASCS spec
Table 3.2: ASE state machine transitions that state transition is
required.
---
 src/shared/bap.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/shared/bap.c b/src/shared/bap.c
index f7e42fc15a81..208fc1bf2958 100644
--- a/src/shared/bap.c
+++ b/src/shared/bap.c
@@ -1965,6 +1965,9 @@ static uint8_t stream_disable(struct bt_bap_stream *stream, struct iovec *rsp)
 	/* Sink can autonomously transit to QOS while source needs to go to
 	 * Disabling until BT_ASCS_STOP is received.
 	 */
+	if (stream->ep->dir == BT_BAP_SINK)
+		stream_set_state(stream, BT_BAP_STREAM_STATE_QOS);
+
 	if (stream->ep->dir == BT_BAP_SOURCE)
 		stream_set_state(stream, BT_BAP_STREAM_STATE_DISABLING);
 
-- 
2.48.1

RE: [BlueZ,v1] shared/bap: Fix state transition of sink for disable operation

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1863 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=939122

---Test result---

Test Summary:
CheckPatch                    PENDING   0.21 seconds
GitLint                       PENDING   0.21 seconds
BuildEll                      PASS      20.47 seconds
BluezMake                     PASS      1437.83 seconds
MakeCheck                     PASS      13.16 seconds
MakeDistcheck                 PASS      157.43 seconds
CheckValgrind                 PASS      212.18 seconds
CheckSmatch                   WARNING   284.54 seconds
bluezmakeextell               PASS      98.80 seconds
IncrementalBuild              PENDING   0.23 seconds
ScanBuild                     PASS      851.41 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: CheckSmatch - WARNING
Desc: Run smatch tool with source
Output:
src/shared/bap.c:305:25: warning: array of flexible structuressrc/shared/bap.c: note: in included file:./src/shared/ascs.h:88:25: warning: array of flexible structuressrc/shared/bap.c:305:25: warning: array of flexible structuressrc/shared/bap.c: note: in included file:./src/shared/ascs.h:88:25: warning: array of flexible structuressrc/shared/bap.c:305:25: warning: array of flexible structuressrc/shared/bap.c: note: in included file:./src/shared/ascs.h:88:25: warning: array of flexible structures
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth

Re: [PATCH BlueZ v1] shared/bap: Fix state transition of sink for disable operation

[patchwork-bot+bluetooth]

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Fri, 28 Feb 2025 12:50:48 -0500 you wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> 
> This fixes a regression introduced by 173045553c15
> ("bap: Fix not generating releasing state") where the Disable operation
> no long caused the transition to QoS configured for Sink, as per ASCS spec
> Table 3.2: ASE state machine transitions that state transition is
> required.
> 
> [...]

Here is the summary with links:
  - [BlueZ,v1] shared/bap: Fix state transition of sink for disable operation
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=9efc138e9808

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html