[PATCH v1] Bluetooth: btintel_pci: Fix build warning

[PATCH v1] Bluetooth: btintel_pci: Fix build warning

[Luiz Augusto von Dentz]

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

This fixes the following warning:

drivers/bluetooth/btintel_pcie.c:695:20: warning: unused function 'btintel_pcie_in_rom' [-Wunused-function]
  695 | static inline bool btintel_pcie_in_rom(struct btintel_pcie_data *data)
      |                    ^~~~~~~~~~~~~~~~~~~

Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
---
 drivers/bluetooth/btintel_pcie.c | 14 --------------
 1 file changed, 14 deletions(-)

diff --git a/drivers/bluetooth/btintel_pcie.c b/drivers/bluetooth/btintel_pcie.c
index f3ab5b41b050..9114be1fc3ce 100644
--- a/drivers/bluetooth/btintel_pcie.c
+++ b/drivers/bluetooth/btintel_pcie.c
@@ -685,20 +685,6 @@ static int btintel_pcie_enable_bt(struct btintel_pcie_data *data)
 	return 0;
 }
 
-/* BIT(0) - ROM, BIT(1) - IML and BIT(3) - OP
- * Sometimes during firmware image switching from ROM to IML or IML to OP image,
- * the previous image bit is not cleared by firmware when alive interrupt is
- * received. Driver needs to take care of these sticky bits when deciding the
- * current image running on controller.
- * Ex: 0x10 and 0x11 - both represents that controller is running IML
- */
-static inline bool btintel_pcie_in_rom(struct btintel_pcie_data *data)
-{
-	return data->boot_stage_cache & BTINTEL_PCIE_CSR_BOOT_STAGE_ROM &&
-		!(data->boot_stage_cache & BTINTEL_PCIE_CSR_BOOT_STAGE_IML) &&
-		!(data->boot_stage_cache & BTINTEL_PCIE_CSR_BOOT_STAGE_OPFW);
-}
-
 static inline bool btintel_pcie_in_op(struct btintel_pcie_data *data)
 {
 	return data->boot_stage_cache & BTINTEL_PCIE_CSR_BOOT_STAGE_OPFW;
-- 
2.48.1

Re: [PATCH v1] Bluetooth: btintel_pci: Fix build warning

[Paul Menzel]

Dear Luiz,


Thank you for your patch. Maybe be more specific in the summary/title. 
Maybe:

Bluetooth: btintel_pci: Remove unused btintel_pcie_in_rom()

Am 06.03.25 um 22:38 schrieb Luiz Augusto von Dentz:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> 
> This fixes the following warning:
> 
> drivers/bluetooth/btintel_pcie.c:695:20: warning: unused function 'btintel_pcie_in_rom' [-Wunused-function]
>    695 | static inline bool btintel_pcie_in_rom(struct btintel_pcie_data *data)
>        |                    ^~~~~~~~~~~~~~~~~~~
> 
> Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> ---
>   drivers/bluetooth/btintel_pcie.c | 14 --------------
>   1 file changed, 14 deletions(-)
> 
> diff --git a/drivers/bluetooth/btintel_pcie.c b/drivers/bluetooth/btintel_pcie.c
> index f3ab5b41b050..9114be1fc3ce 100644
> --- a/drivers/bluetooth/btintel_pcie.c
> +++ b/drivers/bluetooth/btintel_pcie.c
> @@ -685,20 +685,6 @@ static int btintel_pcie_enable_bt(struct btintel_pcie_data *data)
>   	return 0;
>   }
>   
> -/* BIT(0) - ROM, BIT(1) - IML and BIT(3) - OP
> - * Sometimes during firmware image switching from ROM to IML or IML to OP image,
> - * the previous image bit is not cleared by firmware when alive interrupt is
> - * received. Driver needs to take care of these sticky bits when deciding the
> - * current image running on controller.
> - * Ex: 0x10 and 0x11 - both represents that controller is running IML
> - */
> -static inline bool btintel_pcie_in_rom(struct btintel_pcie_data *data)
> -{
> -	return data->boot_stage_cache & BTINTEL_PCIE_CSR_BOOT_STAGE_ROM &&
> -		!(data->boot_stage_cache & BTINTEL_PCIE_CSR_BOOT_STAGE_IML) &&
> -		!(data->boot_stage_cache & BTINTEL_PCIE_CSR_BOOT_STAGE_OPFW);
> -}
> -
>   static inline bool btintel_pcie_in_op(struct btintel_pcie_data *data)
>   {
>   	return data->boot_stage_cache & BTINTEL_PCIE_CSR_BOOT_STAGE_OPFW;

Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>


Kind regards,

Paul

Re: [PATCH v1] Bluetooth: btintel_pci: Fix build warning

[patchwork-bot+bluetooth]

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Thu,  6 Mar 2025 16:38:46 -0500 you wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> 
> This fixes the following warning:
> 
> drivers/bluetooth/btintel_pcie.c:695:20: warning: unused function 'btintel_pcie_in_rom' [-Wunused-function]
>   695 | static inline bool btintel_pcie_in_rom(struct btintel_pcie_data *data)
>       |                    ^~~~~~~~~~~~~~~~~~~
> 
> [...]

Here is the summary with links:
  - [v1] Bluetooth: btintel_pci: Fix build warning
    https://git.kernel.org/bluetooth/bluetooth-next/c/dfa48dfca48e

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html