From: patchwork-bot+bluetooth@kernel.org
To: Yao Zi <ziyao@disroot.org>
Cc: linux-bluetooth@vger.kernel.org, ceggers@arri.de
Subject: Re: [PATCH BlueZ] client/gatt: Fix pointer assigned with character literal
Date: Wed, 26 Mar 2025 15:10:39 +0000 [thread overview]
Message-ID: <174300183900.1347744.10500234051496007504.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20250325083546.31597-2-ziyao@disroot.org>
Hello:
This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:
On Tue, 25 Mar 2025 08:35:47 +0000 you wrote:
> A character literl, '\0', is assigned to the pointer. The corresponding
> comment doesn't make any sense, since '\0' represents zero and this
> statement does the same thing as assigning value with NULL.
>
> Initializing value with NULL (or zero) is safe and correct here: the
> only case that the initial value of the pointer is passed to
> write_value() is that the if branch isn't executed, where len keeps its
> initial value, zero, as well. With src_len equal to zero, write_value()
> will bail out and src_val won't be dereferenced.
>
> [...]
Here is the summary with links:
- [BlueZ] client/gatt: Fix pointer assigned with character literal
https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=0f0039045088
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2025-03-26 15:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-25 8:35 [PATCH BlueZ] client/gatt: Fix pointer assigned with character literal Yao Zi
2025-03-25 9:39 ` [BlueZ] " bluez.test.bot
2025-03-25 10:28 ` [PATCH BlueZ] " Christian Eggers
2025-03-26 15:10 ` patchwork-bot+bluetooth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174300183900.1347744.10500234051496007504.git-patchwork-notify@kernel.org \
--to=patchwork-bot+bluetooth@kernel.org \
--cc=ceggers@arri.de \
--cc=linux-bluetooth@vger.kernel.org \
--cc=ziyao@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox