Re: android/handsfree.c | Possible Fix | Review

[Szymon Janc <szymon.janc@tieto.com>]

Hi Prabhu,

On Wednesday 01 of April 2015 18:40:52 Prabhu Chawandi wrote:
> Hi,
> 
>   When we were testing handsfree we were seeing command is not being
> identified and when looked size was  sent zero when we set it as below
> it started working.
> 
> static const struct ipc_handler sco_handlers[] = {
>         /* SCO_OP_GET_FD */
> -        { bt_sco_get_fd, false, 0 }
> };
> 
> 
> static const struct ipc_handler sco_handlers[] = {
>         /* SCO_OP_GET_FD */
>  +       { bt_sco_get_fd, false, sizeof(struct sco_cmd_get_fd) }
> };

Yes, the fix is correct. Could you send a proper patch for it?
 
> one request -  have you documented anywhere the sequence of commands
> to test each profiles supported till now. if we get the the proper
> sequences we can validate much faster stabilising the code. Else we
> need to spend time in identifying the sequences.
> 
> So, if you have documented anywhere request you to share,

Those sequences are defined by android code (framework or multimedia) and are 
not really documented. You could find some suggestion if you look at our PTS 
testing documentation (android/pts-*.txt) where we do use haltest for tests. 

Note that if possible we prefer to use Android Framework for validation 
instead of haltest (which is mostly development tool).

-- 
BR
Szymon Janc