[PATCH v1] Bluetooth: hci_sync: Fix broadcast announcement size

[PATCH v1] Bluetooth: hci_sync: Fix broadcast announcement size

[Luiz Augusto von Dentz]

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

The advertisement data size of broadcast announcement is always set to
the maximum rather than the actual size:

Before:

< HCI Command: LE Set Exte.. (0x08|0x0037) plen 11
        Handle: 0x01
        Operation: Complete extended advertising data (0x03)
        Fragment preference: Minimize fragmentation (0x01)
        Data length: 0xfb
        Service Data: Broadcast Audio Announcement (0x1852)
        Broadcast ID: 4734947 (0x483fe3)

After:

< HCI Command: LE Set Exte.. (0x08|0x0037) plen 11
        Handle: 0x01
        Operation: Complete extended advertising data (0x03)
        Fragment preference: Minimize fragmentation (0x01)
        Data length: 0x07
        Service Data: Broadcast Audio Announcement (0x1852)
        Broadcast ID: 4734947 (0x483fe3)

Link: https://github.com/bluez/bluez/issues/1117#issuecomment-2959262176
Fixes: b4da091fed83 ("Bluetooth: hci_sync: Fix broadcast/PA when using an existing instance")
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
---
 net/bluetooth/hci_sync.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/net/bluetooth/hci_sync.c b/net/bluetooth/hci_sync.c
index 3d4370c7c26d..5e7eac1c3529 100644
--- a/net/bluetooth/hci_sync.c
+++ b/net/bluetooth/hci_sync.c
@@ -1590,7 +1590,8 @@ static int hci_adv_bcast_annoucement(struct hci_dev *hdev, struct adv_info *adv)
 	get_random_bytes(bid, sizeof(bid));
 	len = eir_append_service_data(ad, 0, 0x1852, bid, sizeof(bid));
 	memcpy(ad + len, adv->adv_data, adv->adv_data_len);
-	hci_set_adv_instance_data(hdev, adv->instance, sizeof(ad), ad, 0, NULL);
+	hci_set_adv_instance_data(hdev, adv->instance, len + adv->adv_data_len,
+				  ad, 0, NULL);
 
 	return hci_update_adv_data_sync(hdev, adv->instance);
 }
-- 
2.49.0

RE: [v1] Bluetooth: hci_sync: Fix broadcast announcement size

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1950 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=970375

---Test result---

Test Summary:
CheckPatch                    PENDING   0.35 seconds
GitLint                       PENDING   0.24 seconds
SubjectPrefix                 PASS      0.15 seconds
BuildKernel                   PASS      24.70 seconds
CheckAllWarning               PASS      26.89 seconds
CheckSparse                   PASS      30.44 seconds
BuildKernel32                 PASS      24.11 seconds
TestRunnerSetup               PASS      461.20 seconds
TestRunner_l2cap-tester       PASS      27.38 seconds
TestRunner_iso-tester         PASS      40.47 seconds
TestRunner_bnep-tester        PASS      5.98 seconds
TestRunner_mgmt-tester        FAIL      133.71 seconds
TestRunner_rfcomm-tester      PASS      9.42 seconds
TestRunner_sco-tester         PASS      15.00 seconds
TestRunner_ioctl-tester       PASS      10.21 seconds
TestRunner_mesh-tester        PASS      7.58 seconds
TestRunner_smp-tester         PASS      8.59 seconds
TestRunner_userchan-tester    PASS      6.37 seconds
IncrementalBuild              PENDING   0.61 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner
Output:
Total: 490, Passed: 485 (99.0%), Failed: 1, Not Run: 4

Failed Test Cases
LL Privacy - Add Device 3 (AL is full)               Failed       0.248 seconds
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth

Re: [PATCH v1] Bluetooth: hci_sync: Fix broadcast announcement size

[patchwork-bot+bluetooth]

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Tue, 10 Jun 2025 09:42:31 -0400 you wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> 
> The advertisement data size of broadcast announcement is always set to
> the maximum rather than the actual size:
> 
> Before:
> 
> [...]

Here is the summary with links:
  - [v1] Bluetooth: hci_sync: Fix broadcast announcement size
    https://git.kernel.org/bluetooth/bluetooth-next/c/1d800f03516c

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html