* [PATCH v1] Bluetooth: hci_sync: Fix attempting to send HCI_Disconnect to BIS handle
@ 2025-07-03 13:54 Luiz Augusto von Dentz
0 siblings, 0 replies; 4+ messages in thread
From: Luiz Augusto von Dentz @ 2025-07-03 13:54 UTC (permalink / raw)
To: linux-bluetooth
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
BIS/PA connections do have their own cleanup proceedure which are
performed by hci_conn_cleanup/bis_cleanup.
Fixes: 23205562ffc8 ("Bluetooth: separate CIS_LINK and BIS_LINK link types")
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
---
net/bluetooth/hci_sync.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/bluetooth/hci_sync.c b/net/bluetooth/hci_sync.c
index ca57eab15169..92a24a82a03f 100644
--- a/net/bluetooth/hci_sync.c
+++ b/net/bluetooth/hci_sync.c
@@ -5493,7 +5493,7 @@ static int hci_disconnect_sync(struct hci_dev *hdev, struct hci_conn *conn,
{
struct hci_cp_disconnect cp;
- if (test_bit(HCI_CONN_BIG_CREATED, &conn->flags)) {
+ if (conn->type == BIS_LINK) {
/* This is a BIS connection, hci_conn_del will
* do the necessary cleanup.
*/
--
2.49.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v1] Bluetooth: hci_sync: Fix attempting to send HCI_Disconnect to BIS handle
@ 2025-07-03 14:15 Luiz Augusto von Dentz
2025-07-03 14:35 ` [v1] " bluez.test.bot
2025-07-03 15:30 ` [PATCH v1] " patchwork-bot+bluetooth
0 siblings, 2 replies; 4+ messages in thread
From: Luiz Augusto von Dentz @ 2025-07-03 14:15 UTC (permalink / raw)
To: linux-bluetooth
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
BIS/PA connections do have their own cleanup proceedure which are
performed by hci_conn_cleanup/bis_cleanup.
Fixes: 23205562ffc8 ("Bluetooth: separate CIS_LINK and BIS_LINK link types")
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
---
net/bluetooth/hci_sync.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/bluetooth/hci_sync.c b/net/bluetooth/hci_sync.c
index ca57eab15169..92a24a82a03f 100644
--- a/net/bluetooth/hci_sync.c
+++ b/net/bluetooth/hci_sync.c
@@ -5493,7 +5493,7 @@ static int hci_disconnect_sync(struct hci_dev *hdev, struct hci_conn *conn,
{
struct hci_cp_disconnect cp;
- if (test_bit(HCI_CONN_BIG_CREATED, &conn->flags)) {
+ if (conn->type == BIS_LINK) {
/* This is a BIS connection, hci_conn_del will
* do the necessary cleanup.
*/
--
2.49.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [v1] Bluetooth: hci_sync: Fix attempting to send HCI_Disconnect to BIS handle
2025-07-03 14:15 [PATCH v1] Bluetooth: hci_sync: Fix attempting to send HCI_Disconnect to BIS handle Luiz Augusto von Dentz
@ 2025-07-03 14:35 ` bluez.test.bot
2025-07-03 15:30 ` [PATCH v1] " patchwork-bot+bluetooth
1 sibling, 0 replies; 4+ messages in thread
From: bluez.test.bot @ 2025-07-03 14:35 UTC (permalink / raw)
To: linux-bluetooth, luiz.dentz
[-- Attachment #1: Type: text/plain, Size: 2536 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=978664
---Test result---
Test Summary:
CheckPatch PENDING 0.42 seconds
GitLint PENDING 0.23 seconds
SubjectPrefix PASS 0.09 seconds
BuildKernel PASS 24.34 seconds
CheckAllWarning PASS 27.13 seconds
CheckSparse PASS 31.62 seconds
BuildKernel32 PASS 24.31 seconds
TestRunnerSetup PASS 472.32 seconds
TestRunner_l2cap-tester PASS 25.26 seconds
TestRunner_iso-tester PASS 36.09 seconds
TestRunner_bnep-tester PASS 6.01 seconds
TestRunner_mgmt-tester FAIL 134.29 seconds
TestRunner_rfcomm-tester PASS 9.34 seconds
TestRunner_sco-tester PASS 14.68 seconds
TestRunner_ioctl-tester PASS 10.05 seconds
TestRunner_mesh-tester FAIL 11.66 seconds
TestRunner_smp-tester PASS 8.54 seconds
TestRunner_userchan-tester PASS 6.29 seconds
IncrementalBuild PENDING 0.58 seconds
Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:
##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:
##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner
Output:
Total: 490, Passed: 482 (98.4%), Failed: 4, Not Run: 4
Failed Test Cases
LL Privacy - Add Device 3 (AL is full) Failed 0.231 seconds
LL Privacy - Set Flags 2 (Enable RL) Failed 0.163 seconds
LL Privacy - Set Flags 3 (2 Devices to RL) Failed 0.202 seconds
LL Privacy - Start Discovery 2 (Disable RL) Failed 0.207 seconds
##############################
Test: TestRunner_mesh-tester - FAIL
Desc: Run mesh-tester with test-runner
Output:
Total: 10, Passed: 8 (80.0%), Failed: 2, Not Run: 0
Failed Test Cases
Mesh - Send cancel - 1 Timed out 2.496 seconds
Mesh - Send cancel - 2 Timed out 2.000 seconds
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] Bluetooth: hci_sync: Fix attempting to send HCI_Disconnect to BIS handle
2025-07-03 14:15 [PATCH v1] Bluetooth: hci_sync: Fix attempting to send HCI_Disconnect to BIS handle Luiz Augusto von Dentz
2025-07-03 14:35 ` [v1] " bluez.test.bot
@ 2025-07-03 15:30 ` patchwork-bot+bluetooth
1 sibling, 0 replies; 4+ messages in thread
From: patchwork-bot+bluetooth @ 2025-07-03 15:30 UTC (permalink / raw)
To: Luiz Augusto von Dentz; +Cc: linux-bluetooth
Hello:
This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:
On Thu, 3 Jul 2025 10:15:43 -0400 you wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
>
> BIS/PA connections do have their own cleanup proceedure which are
> performed by hci_conn_cleanup/bis_cleanup.
>
> Fixes: 23205562ffc8 ("Bluetooth: separate CIS_LINK and BIS_LINK link types")
> Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
>
> [...]
Here is the summary with links:
- [v1] Bluetooth: hci_sync: Fix attempting to send HCI_Disconnect to BIS handle
https://git.kernel.org/bluetooth/bluetooth-next/c/e8eced7eae5f
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-07-03 15:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-03 14:15 [PATCH v1] Bluetooth: hci_sync: Fix attempting to send HCI_Disconnect to BIS handle Luiz Augusto von Dentz
2025-07-03 14:35 ` [v1] " bluez.test.bot
2025-07-03 15:30 ` [PATCH v1] " patchwork-bot+bluetooth
-- strict thread matches above, loose matches on Subject: below --
2025-07-03 13:54 Luiz Augusto von Dentz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox